Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: trunk/src/mojo/services/view_manager/view_manager_connection.cc

Issue 280023002: Revert 269414 "Changes to deletion/ownership of nodes in the cli..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/view_manager/view_manager_connection.h" 5 #include "mojo/services/view_manager/view_manager_connection.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "mojo/public/cpp/bindings/allocation_scope.h" 8 #include "mojo/public/cpp/bindings/allocation_scope.h"
9 #include "mojo/services/view_manager/node.h" 9 #include "mojo/services/view_manager/node.h"
10 #include "mojo/services/view_manager/root_node_manager.h" 10 #include "mojo/services/view_manager/root_node_manager.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 const NodeId& node, 122 const NodeId& node,
123 const ViewId& new_view_id, 123 const ViewId& new_view_id,
124 const ViewId& old_view_id, 124 const ViewId& old_view_id,
125 TransportChangeId change_id) { 125 TransportChangeId change_id) {
126 client()->OnNodeViewReplaced(NodeIdToTransportId(node), 126 client()->OnNodeViewReplaced(NodeIdToTransportId(node),
127 ViewIdToTransportId(new_view_id), 127 ViewIdToTransportId(new_view_id),
128 ViewIdToTransportId(old_view_id), 128 ViewIdToTransportId(old_view_id),
129 change_id); 129 change_id);
130 } 130 }
131 131
132 void ViewManagerConnection::NotifyNodeDeleted(const NodeId& node,
133 TransportChangeId change_id) {
134 client()->OnNodeDeleted(NodeIdToTransportId(node), change_id);
135 }
136
137 bool ViewManagerConnection::DeleteNodeImpl(ViewManagerConnection* source, 132 bool ViewManagerConnection::DeleteNodeImpl(ViewManagerConnection* source,
138 const NodeId& node_id, 133 const NodeId& node_id,
139 TransportChangeId change_id) { 134 TransportChangeId change_id) {
140 DCHECK_EQ(node_id.connection_id, id_); 135 DCHECK_EQ(node_id.connection_id, id_);
141 Node* node = GetNode(node_id); 136 Node* node = GetNode(node_id);
142 if (!node) 137 if (!node)
143 return false; 138 return false;
144 RootNodeManager::ScopedChange change(source, context(), change_id); 139 RootNodeManager::ScopedChange change(source, context(), change_id);
145 if (node->GetParent()) 140 if (node->GetParent())
146 node->GetParent()->Remove(node); 141 node->GetParent()->Remove(node);
147 std::vector<Node*> children(node->GetChildren()); 142 std::vector<Node*> children(node->GetChildren());
148 for (size_t i = 0; i < children.size(); ++i) 143 for (size_t i = 0; i < children.size(); ++i)
149 node->Remove(children[i]); 144 node->Remove(children[i]);
150 DCHECK(node->GetChildren().empty()); 145 DCHECK(node->GetChildren().empty());
151 node_map_.erase(node_id.node_id); 146 node_map_.erase(node_id.node_id);
152 delete node; 147 delete node;
153 context()->NotifyNodeDeleted(node_id);
154 return true; 148 return true;
155 } 149 }
156 150
157 bool ViewManagerConnection::DeleteViewImpl(ViewManagerConnection* source, 151 bool ViewManagerConnection::DeleteViewImpl(ViewManagerConnection* source,
158 const ViewId& view_id, 152 const ViewId& view_id,
159 TransportChangeId change_id) { 153 TransportChangeId change_id) {
160 DCHECK_EQ(view_id.connection_id, id_); 154 DCHECK_EQ(view_id.connection_id, id_);
161 View* view = GetView(view_id); 155 View* view = GetView(view_id);
162 if (!view) 156 if (!view)
163 return false; 157 return false;
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 300
307 void ViewManagerConnection::OnNodeViewReplaced(const NodeId& node, 301 void ViewManagerConnection::OnNodeViewReplaced(const NodeId& node,
308 const ViewId& new_view_id, 302 const ViewId& new_view_id,
309 const ViewId& old_view_id) { 303 const ViewId& old_view_id) {
310 context()->NotifyNodeViewReplaced(node, new_view_id, old_view_id); 304 context()->NotifyNodeViewReplaced(node, new_view_id, old_view_id);
311 } 305 }
312 306
313 } // namespace view_manager 307 } // namespace view_manager
314 } // namespace services 308 } // namespace services
315 } // namespace mojo 309 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698