Use reference parameters when constructing IIRFilterNode's

Use reference parameters when constructing IIRFilterNode's

Use reference parameters so new copies of Vectors aren't created.

BUG=709605
TEST=none; no visible changes

Review-Url: https://codereview.chromium.org/2800203002
Cr-Commit-Position: refs/heads/master@{#463433}
Committed: https://chromium.googlesource.com/chromium/src/+/4b4a31d9f95869f6efc1fee07942eb913140ae5d

[Raymond Toy, 2017-04-10 17:56:51]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-10 17:56:51]

PTAL.  The change is really simple.

[hongchan, 2017-04-10 19:47:31]

https://codereview.chromium.org/2800203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://codereview.chromium.org/2800203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:43: const
Vector<double>& numerator);
The who holds the actual copy of this vector?

[Raymond Toy, 2017-04-10 19:54:49]

https://codereview.chromium.org/2800203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://codereview.chromium.org/2800203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:43: const
Vector<double>& numerator);
On 2017/04/10 19:47:31, hongchan wrote:
> The who holds the actual copy of this vector?

v8 calls IIRFilterNode::Create with the actual coefficients.

[hongchan, 2017-04-10 21:05:11]

lgtm

https://codereview.chromium.org/2800203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://codereview.chromium.org/2800203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:43: const
Vector<double>& numerator);
On 2017/04/10 19:54:49, Raymond Toy wrote:
> On 2017/04/10 19:47:31, hongchan wrote:
> > The who holds the actual copy of this vector?
> 
> v8 calls IIRFilterNode::Create with the actual coefficients.

Acknowledged.

[Raymond Toy, 2017-04-10 21:24:14]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:24:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 22:58:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491859454039430,
"parent_rev": "b03d40ddb1f2055726b64457ea5a41d29fb6223f", "commit_rev":
"4b4a31d9f95869f6efc1fee07942eb913140ae5d"}

[commit-bot: I haz the power, 2017-04-10 22:59:56]

Description was changed from

==========
Use reference parameters when constructing IIRFilterNode's

Use reference parameters so new copies of Vectors aren't created.

BUG=709605
TEST=none; no visible changes
==========

to

==========
Use reference parameters when constructing IIRFilterNode's

Use reference parameters so new copies of Vectors aren't created.

BUG=709605
TEST=none; no visible changes

Review-Url: https://codereview.chromium.org/2800203002
Cr-Commit-Position: refs/heads/master@{#463433}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b4a31d9f95869f6efc1fee07942...
==========

[commit-bot: I haz the power, 2017-04-10 22:59:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b4a31d9f95869f6efc1fee07942...