Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h

Issue 2800203002: Use reference parameters when constructing IIRFilterNode's (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h b/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
index 0ec8f7ec34987da8aaab6e01ae342fb166fa9fd7..e16b8db569cddc57aa12c0823f443ddf2815a37d 100644
--- a/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
@@ -20,8 +20,8 @@ class IIRFilterNode : public AudioNode {
public:
static IIRFilterNode* Create(BaseAudioContext&,
- const Vector<double> feedforward,
- const Vector<double> feedback,
+ const Vector<double>& feedforward,
+ const Vector<double>& feedback,
ExceptionState&);
static IIRFilterNode* Create(BaseAudioContext*,
@@ -39,8 +39,8 @@ class IIRFilterNode : public AudioNode {
private:
IIRFilterNode(BaseAudioContext&,
- const Vector<double> denominator,
- const Vector<double> numerator);
+ const Vector<double>& denominator,
+ const Vector<double>& numerator);
hongchan 2017/04/10 19:47:31 The who holds the actual copy of this vector?
Raymond Toy 2017/04/10 19:54:49 v8 calls IIRFilterNode::Create with the actual coe
hongchan 2017/04/10 21:05:11 Acknowledged.
IIRProcessor* IirProcessor() const;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698