Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2800163002: Prevent excessive beeping in case of Find On Page search failure

Created:
3 years, 8 months ago by elawrence
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent excessive beeping in case of Find On Page search failure Previously, Chrome would beep when updating the find on page result count if a frame was added or removed from the page and there were no search matches. Now Chrome will only beep in response to a user's query failing to find results in the frames of the page at the time of the initial query. Subsequent addition or removal of frames will still update the result counter. BUG=682299

Patch Set 1 #

Patch Set 2 : Move tracking to find_tab_helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698