Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7553)

Unified Diff: chrome/browser/ui/find_bar/find_tab_helper.h

Issue 2800163002: Prevent excessive beeping in case of Find On Page search failure
Patch Set: Move tracking to find_tab_helper Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | chrome/browser/ui/find_bar/find_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_tab_helper.h
diff --git a/chrome/browser/ui/find_bar/find_tab_helper.h b/chrome/browser/ui/find_bar/find_tab_helper.h
index 2f3f05bc5052974ea7e15a4d0ce8ca23edfedd10..37b60ce1b38987bdbf934468b8594f69c29b696e 100644
--- a/chrome/browser/ui/find_bar/find_tab_helper.h
+++ b/chrome/browser/ui/find_bar/find_tab_helper.h
@@ -20,8 +20,8 @@ class FindTabHelper : public content::WebContentsObserver,
~FindTabHelper() override;
// Starts the Find operation by calling StartFinding on the Tab. This function
- // can be called from the outside as a result of hot-keys, so it uses the
- // last remembered search string as specified with set_find_string(). This
+ // can be called from the outside as a result of hot-keys, so if
+ // |search_string| is null, it finds the last remembered search string. This
// function does not block while a search is in progress. The controller will
// receive the results through the notification mechanism. See Observe(...)
// for details.
@@ -112,6 +112,10 @@ class FindTabHelper : public content::WebContentsObserver,
// current session, which also uniquely identifies the session.
int current_find_session_id_;
+ // True if HandleFindReply has received a |final_update| notification for the
+ // current request.
+ bool final_update_received_for_current_query_;
+
// The current string we are/just finished searching for. This is used to
// figure out if this is a Find or a FindNext operation (FindNext should not
// increase the request id).
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | chrome/browser/ui/find_bar/find_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698