Prevent excessive beeping in case of Find On Page search failure

chrome/browser/ui/find_bar/find_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
 
 #include <vector>
 
 #include "base/strings/string_util.h"
 #include "build/build_config.h"
@@ skipping 17 matching lines @@
 // static
 int FindTabHelper::find_request_id_counter_ = -1;
 
 FindTabHelper::FindTabHelper(WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       find_ui_active_(false),
       find_op_aborted_(false),
       current_find_request_id_(find_request_id_counter_++),
       current_find_session_id_(current_find_request_id_),
       last_search_case_sensitive_(false),
-      last_search_result_() {
-}
+      last_search_result_(),
+      final_update_received_for_current_query_(false) {}
 
 FindTabHelper::~FindTabHelper() {
 }
 
 void FindTabHelper::StartFinding(base::string16 search_string,
                                  bool forward_direction,
                                  bool case_sensitive) {
   // Remove the carriage return character, which generally isn't in web content.
   const base::char16 kInvalidChars[] = { '\r', 0 };
   base::RemoveChars(search_string, kInvalidChars, &search_string);
@@ skipping 31 matching lines @@
 
   current_find_request_id_ = find_request_id_counter_++;
   if (!find_next)
     current_find_session_id_ = current_find_request_id_;
 
   if (!search_string.empty())
     find_text_ = search_string;
   last_search_case_sensitive_ = case_sensitive;
 
   find_op_aborted_ = false;
+  final_update_received_for_current_query_ = false;
 
   // Keep track of what the last search was across the tabs.
   Profile* profile =
       Profile::FromBrowserContext(web_contents()->GetBrowserContext());
   FindBarState* find_bar_state = FindBarStateFactory::GetForProfile(profile);
   find_bar_state->set_last_prepopulate_text(find_text_);
 
   WebFindOptions options;
   options.forward = forward_direction;
   options.matchCase = case_sensitive;
@@ skipping 66 matching lines @@
       number_of_matches = last_search_result_.number_of_matches();
     if (active_match_ordinal == -1)
       active_match_ordinal = last_search_result_.active_match_ordinal();
 
     gfx::Rect selection = selection_rect;
     if (final_update && active_match_ordinal == 0)
       selection = gfx::Rect();
     else if (selection_rect.IsEmpty())
       selection = last_search_result_.selection_rect();
 
+    // Don't report more than one "final update" for a given query. See
+    // https://crbug.com/682299.
+    if (final_update) {
+      if (final_update_received_for_current_query_)
+        final_update = false;
+      else
+        final_update_received_for_current_query_ = true;
+    }
+
     // Notify the UI, automation and any other observers that a find result was
     // found.
     last_search_result_ = FindNotificationDetails(
         request_id, number_of_matches, selection, active_match_ordinal,
         final_update);
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_FIND_RESULT_AVAILABLE,
         content::Source<WebContents>(web_contents()),
         content::Details<FindNotificationDetails>(&last_search_result_));
   }
 }