Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2800053002: [crankshaft] Bump the fast literal properties budget. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Bump the fast literal properties budget. Port of http://crrev.com/2805613002 in TurboFan to Crankshaft. We have a weird performance cliff, where using an object literal for allocation is way slower than using a constructor function, or starting from the empty object literal and using transitioning stores. The reason is that we limit the inlining of object literal nodes into Crankshaft to max. 8 fast properties. So as soon as you get above 8, you'll get a runtime function call to %CreateObjectLiteral, which is a lot slower than the inlined allocation and initialization. Still not ideal, but less unpredictable (hopefully). TBR=jarin@chromium.org BUG=v8:6211 Review-Url: https://codereview.chromium.org/2800053002 Cr-Commit-Position: refs/heads/master@{#44464} Committed: https://chromium.googlesource.com/v8/v8/+/12ab9484ee6ae479ec1f929b943bd63d5ef80f3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800053002/1
3 years, 8 months ago (2017-04-07 04:11:32 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 04:35:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/12ab9484ee6ae479ec1f929b943bd63d5ef...

Powered by Google App Engine
This is Rietveld 408576698