Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: src/crankshaft/hydrogen.h

Issue 2800053002: [crankshaft] Bump the fast literal properties budget. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.h
diff --git a/src/crankshaft/hydrogen.h b/src/crankshaft/hydrogen.h
index 83594c8514586ae7683b3bda4fe37c22b5405150..9b2e710d57eb01c2427a14eafde69bc46ab3f4f8 100644
--- a/src/crankshaft/hydrogen.h
+++ b/src/crankshaft/hydrogen.h
@@ -2115,9 +2115,13 @@ class HOptimizedGraphBuilder : public HGraphBuilder,
static const int kUnlimitedMaxInlinedNodesCumulative = 10000;
// Maximum depth and total number of elements and properties for literal
- // graphs to be considered for fast deep-copying.
+ // graphs to be considered for fast deep-copying. The limit is chosen to
+ // match the maximum number of inobject properties, to ensure that the
+ // performance of using object literals is not worse than using constructor
+ // functions, see crbug.com/v8/6211 for details.
static const int kMaxFastLiteralDepth = 3;
- static const int kMaxFastLiteralProperties = 8;
+ static const int kMaxFastLiteralProperties =
+ (JSObject::kMaxInstanceSize - JSObject::kHeaderSize) >> kPointerSizeLog2;
// Simple accessors.
void set_function_state(FunctionState* state) { function_state_ = state; }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698