Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2800043003:
Use correct define for identifying MSVC compiler (Closed)
|
Created:
3 years, 8 months ago by brucedawson Modified:
3 years, 8 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
DescriptionUse correct define for identifying MSVC compiler
Optimizations are supposed to be disabled in our stack-trace code when
building with VC++. However the check used #if defined(COMPILER_MSVC)
when that is never defined in v8. The correct define in v8 is
V8_CC_MSVC.
R=hablich@chromium.org
Review-Url: https://codereview.chromium.org/2800043003
Cr-Commit-Position: refs/heads/master@{#44621}
Committed: https://chromium.googlesource.com/v8/v8/+/aba400985853b5b1a306b4d4a14fe3d9088cebe7
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
I found this while working on https://codereview.chromium.org/2804033005. Presumably we should either delete this code or apply this fix. I think applying this fix is the correct thing to do.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use correct define for identifying MSVC compiler Optimizations are supposed to be disabled in our stack-trace code when building with VC++. However the check used #if defined(COMPILER_MSVC) when that is never defined in v8. The correct define in v8 is V8_CC_MSVC. R=hablich@chromium.org ========== to ========== Use correct define for identifying MSVC compiler Optimizations are supposed to be disabled in our stack-trace code when building with VC++. However the check used #if defined(COMPILER_MSVC) when that is never defined in v8. The correct define in v8 is V8_CC_MSVC. R=hablich@chromium.org ==========
hablich@chromium.org changed reviewers: + machenbach@chromium.org, yangguo@chromium.org
hablich@chromium.org changed reviewers: - hablich@chromium.org
hablich@chromium.org changed reviewers: + jgruber@chromium.org - machenbach@chromium.org
On 2017/04/07 20:56:26, brucedawson wrote: > I found this while working on https://codereview.chromium.org/2804033005. > Presumably we should either delete this code or apply this fix. I think applying > this fix is the correct thing to do. Removed myself from the reviewers. Added Yang and Jakok, they know the debugger best.
On 2017/04/12 08:03:22, Michael Hablich wrote: > On 2017/04/07 20:56:26, brucedawson wrote: > > I found this while working on https://codereview.chromium.org/2804033005. > > Presumably we should either delete this code or apply this fix. I think > applying > > this fix is the correct thing to do. > > Removed myself from the reviewers. Added Yang and Jakok, they know the debugger > best. lgtm.
lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492016010736610, "parent_rev":
"148ff7394db2f51103970cee248f94db82af747b", "commit_rev":
"aba400985853b5b1a306b4d4a14fe3d9088cebe7"}
Message was sent while issue was closed.
Description was changed from ========== Use correct define for identifying MSVC compiler Optimizations are supposed to be disabled in our stack-trace code when building with VC++. However the check used #if defined(COMPILER_MSVC) when that is never defined in v8. The correct define in v8 is V8_CC_MSVC. R=hablich@chromium.org ========== to ========== Use correct define for identifying MSVC compiler Optimizations are supposed to be disabled in our stack-trace code when building with VC++. However the check used #if defined(COMPILER_MSVC) when that is never defined in v8. The correct define in v8 is V8_CC_MSVC. R=hablich@chromium.org Review-Url: https://codereview.chromium.org/2800043003 Cr-Commit-Position: refs/heads/master@{#44621} Committed: https://chromium.googlesource.com/v8/v8/+/aba400985853b5b1a306b4d4a14fe3d9088... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/aba400985853b5b1a306b4d4a14fe3d9088... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
