Suppress incorrect warning

Suppress incorrect warning

When doing VS 2017 official builds of some targets, including
mksnapshot.exe, a warning about a buffer overrun is shown. After
analysis and discussion with Microsoft it was decided that this warning
is spurious. The warning is:

    warning C4789: buffer 'key' of size 16 bytes will be overrun; 4
    bytes will be written starting at offset 16

Despite the certain language "4 bytes *will* be written..." it is in
fact a heuristic based warning. Suppressing it at this point in the
inlining stack appears to avoid the issues.

R=hablich@chromium.org
BUG=v8:6068
Review-Url: https://codereview.chromium.org/2804033005
Cr-Commit-Position: refs/heads/master@{#44625}
Committed: https://chromium.googlesource.com/v8/v8/+/9c1dcfd9114e7f3ee9ebfe3785532c8443c29f01

[brucedawson, 2017-04-07 20:48:40]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 20:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-04-07 20:49:19]

This 2017 warning is wrong. This suppression makes it go away, at least when
doing official builds of mksnapshot.exe in a Chromium enlistment with 2017.

[commit-bot: I haz the power, 2017-04-07 21:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:28:27]

Dry run: This issue passed the CQ dry run.

[Michael Hablich, 2017-04-12 07:59:55]

Description was changed from

==========
Suppress incorrect warning

When doing VS 2017 official builds of some targets, including
mksnapshot.exe, a warning about a buffer overrun is shown. After
analysis and discussion with Microsoft it was decided that this warning
is spurious. The warning is:

    warning C4789: buffer 'key' of size 16 bytes will be overrun; 4
    bytes will be written starting at offset 16

Despite the certain language "4 bytes *will* be written..." it is in
fact a heuristic based warning. Suppressing it at this point in the
inlining stack appears to avoid the issues.

R=hablich@chromium.org
BUG=v8:6068
==========

to

==========
Suppress incorrect warning

When doing VS 2017 official builds of some targets, including
mksnapshot.exe, a warning about a buffer overrun is shown. After
analysis and discussion with Microsoft it was decided that this warning
is spurious. The warning is:

    warning C4789: buffer 'key' of size 16 bytes will be overrun; 4
    bytes will be written starting at offset 16

Despite the certain language "4 bytes *will* be written..." it is in
fact a heuristic based warning. Suppressing it at this point in the
inlining stack appears to avoid the issues.

R=hablich@chromium.org
BUG=v8:6068
==========

[Michael Hablich, 2017-04-12 07:59:55]

hablich@chromium.org changed reviewers:
+ machenbach@chromium.org, yangguo@chromium.org

[Michael Hablich, 2017-04-12 08:01:06]

On 2017/04/07 20:49:19, brucedawson wrote:
> This 2017 warning is wrong. This suppression makes it go away, at least when
> doing official builds of mksnapshot.exe in a Chromium enlistment with 2017.

lgtm. Added two other reviewers who have an overview of our build setup.

[Michael Achenbach, 2017-04-12 08:58:59]

lgtm

[brucedawson, 2017-04-12 18:38:13]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-04-12 18:38:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 19:07:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492022293948890, "parent_rev":
"aee49387f7fc9a79fd7209b5c1012532a14f6de5", "commit_rev":
"9c1dcfd9114e7f3ee9ebfe3785532c8443c29f01"}

[commit-bot: I haz the power, 2017-04-12 19:07:33]

Description was changed from

==========
Suppress incorrect warning

When doing VS 2017 official builds of some targets, including
mksnapshot.exe, a warning about a buffer overrun is shown. After
analysis and discussion with Microsoft it was decided that this warning
is spurious. The warning is:

    warning C4789: buffer 'key' of size 16 bytes will be overrun; 4
    bytes will be written starting at offset 16

Despite the certain language "4 bytes *will* be written..." it is in
fact a heuristic based warning. Suppressing it at this point in the
inlining stack appears to avoid the issues.

R=hablich@chromium.org
BUG=v8:6068
==========

to

==========
Suppress incorrect warning

When doing VS 2017 official builds of some targets, including
mksnapshot.exe, a warning about a buffer overrun is shown. After
analysis and discussion with Microsoft it was decided that this warning
is spurious. The warning is:

    warning C4789: buffer 'key' of size 16 bytes will be overrun; 4
    bytes will be written starting at offset 16

Despite the certain language "4 bytes *will* be written..." it is in
fact a heuristic based warning. Suppressing it at this point in the
inlining stack appears to avoid the issues.

R=hablich@chromium.org
BUG=v8:6068

Review-Url: https://codereview.chromium.org/2804033005
Cr-Commit-Position: refs/heads/master@{#44625}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c1dcfd9114e7f3ee9ebfe3785532c8443c...
==========

[commit-bot: I haz the power, 2017-04-12 19:07:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9c1dcfd9114e7f3ee9ebfe3785532c8443c...