Chromium Code Reviews
Description[Merge to M58] Deprecate Alt+Shift+K and replace it by Search+Shift+K
This shortcut was newly added and should have been a Search-based
key from the beginning. It conflicts with A Google Sheets shortcut.
Screenshots:
1- https://screenshot.googleplex.com/ki3aepLOBRq.png
2- https://screenshot.googleplex.com/G6hj96dyfRo.png
TBR=xiyuan@chromium.org, jamescook@chromium.org, mpearson@chromium.org
BUG=706018
TEST=covered by tests in ash_unittests.
TEST=manually: Should see the deprecated notification when using the
old shortcut. Should see an entry for the new one in the
keyboard overlay.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2784393002
Cr-Commit-Position: refs/heads/master@{#461151}
(cherry picked from commit af7963debe7aee03e201ea8ead465a7cbcff86cb)
Review-Url: https://codereview.chromium.org/2799973002 .
Cr-Commit-Position: refs/branch-heads/3029@{#618}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/579880a51bcd7ec59e66d85d2d764a536cd06530
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||