Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2799973002: [Merge to M58] Deprecate Alt+Shift+K and replace it by Search+Shift+K (Closed)

Created:
3 years, 8 months ago by afakhry
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, James Cook, Mark P
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, oshima+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, kalyank
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58] Deprecate Alt+Shift+K and replace it by Search+Shift+K This shortcut was newly added and should have been a Search-based key from the beginning. It conflicts with A Google Sheets shortcut. Screenshots: 1- https://screenshot.googleplex.com/ki3aepLOBRq.png 2- https://screenshot.googleplex.com/G6hj96dyfRo.png TBR=xiyuan@chromium.org, jamescook@chromium.org, mpearson@chromium.org BUG=706018 TEST=covered by tests in ash_unittests. TEST=manually: Should see the deprecated notification when using the old shortcut. Should see an entry for the new one in the keyboard overlay. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2784393002 Cr-Commit-Position: refs/heads/master@{#461151} (cherry picked from commit af7963debe7aee03e201ea8ead465a7cbcff86cb) Review-Url: https://codereview.chromium.org/2799973002 . Cr-Commit-Position: refs/branch-heads/3029@{#618} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/579880a51bcd7ec59e66d85d2d764a536cd06530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_strings.grd View 2 chunks +10 lines, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
afakhry
Committed patchset #1 (id:1) manually as 579880a51bcd7ec59e66d85d2d764a536cd06530 (presubmit successful).
3 years, 8 months ago (2017-04-06 23:49:54 UTC) #2
Mark P
3 years, 8 months ago (2017-04-07 05:11:30 UTC) #3
Message was sent while issue was closed.
histograms.xml lgtm for the record

--mark

Powered by Google App Engine
This is Rietveld 408576698