Deprecate Alt+Shift+K and replace it by Search+Shift+K

Deprecate Alt+Shift+K and replace it by Search+Shift+K

This shortcut was newly added and should have been a Search-based
key from the beginning. It conflicts with A Google Sheets shortcut.

Screenshots:
1- https://screenshot.googleplex.com/ki3aepLOBRq.png
2- https://screenshot.googleplex.com/G6hj96dyfRo.png

BUG=706018
TEST=covered by tests in ash_unittests.
TEST=manually: Should see the deprecated notification when using the
     old shortcut. Should see an entry for the new one in the
     keyboard overlay.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2784393002
Cr-Commit-Position: refs/heads/master@{#461151}
Committed: https://chromium.googlesource.com/chromium/src/+/af7963debe7aee03e201ea8ead465a7cbcff86cb

[afakhry, 2017-03-30 18:54:34]

Description was changed from

==========
Deprecate Alt+Shift+K and replace it by Search+Shift+K

This shortcut was newly added and should have been a Search-based
key from the beginning. It conflicts with A Google Sheets shortcut.

Screenshots:
1- https://screenshot.googleplex.com/ki3aepLOBRq.png
2- https://screenshot.googleplex.com/G6hj96dyfRo.png

BUG=706018
TEST=covered by tests in ash_unittests.
TEST=manually: Should see the deprecated notification when using the
     old shortcut. Should see an entry for the new one in the
     keyboard overlay.
==========

to

==========
Deprecate Alt+Shift+K and replace it by Search+Shift+K

This shortcut was newly added and should have been a Search-based
key from the beginning. It conflicts with A Google Sheets shortcut.

Screenshots:
1- https://screenshot.googleplex.com/ki3aepLOBRq.png
2- https://screenshot.googleplex.com/G6hj96dyfRo.png

BUG=706018
TEST=covered by tests in ash_unittests.
TEST=manually: Should see the deprecated notification when using the
     old shortcut. Should see an entry for the new one in the
     keyboard overlay.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-03-30 18:58:54]

Patchset #1 (id:1) has been deleted

[afakhry, 2017-03-30 18:59:15]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:00:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-03-30 20:43:29]

afakhry@chromium.org changed reviewers:
+ jamescook@chromium.org

[afakhry, 2017-03-30 20:43:29]

James, please take a look. Although I'm not sure if that will help Google Sheets
since the old shortcut will still be enabled.

[commit-bot: I haz the power, 2017-03-30 21:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:34:45]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-03-30 22:57:25]

Code LGTM and we never should have put the key on Alt-Shift-K. Sorry I approved
that CL.

I did ping the bug because we need an answer for other Alt-Shift shortcuts.

[afakhry, 2017-03-31 01:06:23]

afakhry@chromium.org changed reviewers:
+ mpearson@chromium.org, xiyuan@chromium.org

[afakhry, 2017-03-31 01:06:23]

Thanks, James!

+xiyuan@ for chrome/
+mpearson@ for tools/

Thanks!

[xiyuan, 2017-03-31 15:13:21]

lgtm

[Mark P, 2017-03-31 16:34:35]

histograms.xml lgtm

[afakhry, 2017-03-31 16:37:17]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:37:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 16:51:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490978237977490,
"parent_rev": "0c28090a57ec3bcfe04243b8419ce3abc1c49637", "commit_rev":
"af7963debe7aee03e201ea8ead465a7cbcff86cb"}

[commit-bot: I haz the power, 2017-03-31 16:52:43]

Description was changed from

==========
Deprecate Alt+Shift+K and replace it by Search+Shift+K

This shortcut was newly added and should have been a Search-based
key from the beginning. It conflicts with A Google Sheets shortcut.

Screenshots:
1- https://screenshot.googleplex.com/ki3aepLOBRq.png
2- https://screenshot.googleplex.com/G6hj96dyfRo.png

BUG=706018
TEST=covered by tests in ash_unittests.
TEST=manually: Should see the deprecated notification when using the
     old shortcut. Should see an entry for the new one in the
     keyboard overlay.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Deprecate Alt+Shift+K and replace it by Search+Shift+K

This shortcut was newly added and should have been a Search-based
key from the beginning. It conflicts with A Google Sheets shortcut.

Screenshots:
1- https://screenshot.googleplex.com/ki3aepLOBRq.png
2- https://screenshot.googleplex.com/G6hj96dyfRo.png

BUG=706018
TEST=covered by tests in ash_unittests.
TEST=manually: Should see the deprecated notification when using the
     old shortcut. Should see an entry for the new one in the
     keyboard overlay.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2784393002
Cr-Commit-Position: refs/heads/master@{#461151}
Committed:
https://chromium.googlesource.com/chromium/src/+/af7963debe7aee03e201ea8ead46...
==========

[commit-bot: I haz the power, 2017-03-31 16:52:44]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af7963debe7aee03e201ea8ead46...