🔍 Clean up the search widget code

🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG=708844
SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ

Review-Url: https://codereview.chromium.org/2799783003
Cr-Commit-Position: refs/heads/master@{#462931}
Committed: https://chromium.googlesource.com/chromium/src/+/e63e28f00da6f1670b2a72d8511f70259b294e4c

[gone, 2017-04-06 00:52:13]

dfalcantara@chromium.org changed reviewers:
+ yusufo@chromium.org

[gone, 2017-04-07 02:18:39]

Description was changed from

==========
🔍 Clean up the search widget

It's technically infeasible to assume that the search box
can animate to the correct location all the time.  Instead,
just remove all of this code and keep it simple.

BUG=708844
==========

to

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

BUG=708844
==========

[gone, 2017-04-07 02:20:52]

Description was changed from

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

BUG=708844
==========

to

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG=708844
==========

[gone, 2017-04-07 02:22:25]

Description was changed from

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG=708844
==========

to

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG=708844
SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ
==========

[gone, 2017-04-07 02:24:41]

Hadn't heard from you so I threw more changes in.  PTAL.

[gone, 2017-04-07 02:43:43]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 02:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 04:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 04:22:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gone, 2017-04-07 17:08:04]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:08:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:35:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:35:29]

Dry run: This issue passed the CQ dry run.

[Yusuf, 2017-04-07 18:08:28]

lgtm with a nit

https://codereview.chromium.org/2799783003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
(right):

https://codereview.chromium.org/2799783003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java:215:
private void focusTextBox(boolean clearQuery) {
maybe this should be in the SearchLocationBar class itself?

[gone, 2017-04-07 18:15:26]

https://codereview.chromium.org/2799783003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
(right):

https://codereview.chromium.org/2799783003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java:215:
private void focusTextBox(boolean clearQuery) {
On 2017/04/07 18:08:28, Yusuf wrote:
> maybe this should be in the SearchLocationBar class itself?

Talked offline:
There's a lot more cleanup to be done in this class.  Will punt for a followup.

[gone, 2017-04-07 18:15:30]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:16:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:25:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491588930810550,
"parent_rev": "00283c09b0e6479e55fd4630f49601f167fc10b0", "commit_rev":
"e63e28f00da6f1670b2a72d8511f70259b294e4c"}

[commit-bot: I haz the power, 2017-04-07 18:25:59]

Description was changed from

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG=708844
SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ
==========

to

==========
🔍 Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG=708844
SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ

Review-Url: https://codereview.chromium.org/2799783003
Cr-Commit-Position: refs/heads/master@{#462931}
Committed:
https://chromium.googlesource.com/chromium/src/+/e63e28f00da6f1670b2a72d8511f...
==========

[commit-bot: I haz the power, 2017-04-07 18:26:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e63e28f00da6f1670b2a72d8511f...