chrome/android/java/res/layout/search_activity.xml - Issue 2799783003: 🔍 Clean up the search widget code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/search_activity.xml

Issue 2799783003: 🔍 Clean up the search widget code (Closed)

Patch Set: 🔍 Clean up the search widget Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/search_widget_template_transparent.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:id="@+id/control_container"

	8 android:layout_width="match_parent"

	9 android:layout_height="match_parent"

	10 android:background="#9affffff" >

	11

	12 <!-- This view is unnecessary visually, but required for the LocationBarLayo ut. -->

	13 <org.chromium.chrome.browser.searchwidget.SearchActivityFadingBackgroundView

	14 android:id="@+id/fading_focus_target"

	15 android:layout_width="0dp"

	16 android:layout_height="0dp" />

	17

	18 <ViewStub

	19 android:id="@+id/omnibox_results_container_stub"

	20 android:layout_width="match_parent"

	21 android:layout_height="wrap_content"

	22 android:background="@android:color/white"

	23 android:layout="@layout/omnibox_results_container" />

	24

	25 <ImageView

	26 android:id="@+id/toolbar_shadow"

	27 android:src="@drawable/toolbar_shadow"

	28 android:layout_width="match_parent"

	29 android:layout_height="wrap_content"

	30 android:layout_marginTop="@dimen/toolbar_height_no_shadow"

	31 android:scaleType="fitXY"

	32 android:contentDescription="@null" />

	33

	34 <FrameLayout

	35 android:id="@+id/toolbar"

	36 android:layout_width="match_parent"

	37 android:layout_height="@dimen/toolbar_height_no_shadow"

	38 android:background="@android:color/white"

	39 android:clickable="true" >

	40

	41 <!-- TODO(dfalcantara): Ask UX about what to do for tablets. -->

	42 <org.chromium.chrome.browser.searchwidget.SearchActivityLocationBarLayou t

	43 android:id="@+id/search_location_bar"

	44 android:layout_width="match_parent"

	45 android:layout_height="wrap_content"

	46 android:layout_marginStart="@dimen/tablet_toolbar_start_padding_ no_buttons"

	47 android:layout_marginEnd="@dimen/tablet_toolbar_start_padding_no _buttons"

	48 android:layout_marginTop="@dimen/tablet_toolbar_start_padding_no _buttons" />

	49

	50 </FrameLayout>

	51

	52 <FrameLayout

	53 android:id="@+id/bottom_container"

	54 android:layout_width="match_parent"

	55 android:layout_height="match_parent" />

	56

	57 </FrameLayout>

OLD	NEW