Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2799743005: Revert of cc: Always log shader compiler errors (Closed)

Created:
3 years, 8 months ago by ccameron
Modified:
3 years, 8 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Always log shader compiler errors (patchset #2 id:20001 of https://codereview.chromium.org/2712033004/ ) Reason for revert: Causes performance regression BUG=699743 Original issue's description: > cc: Always log shader compiler errors > > This is a catastrophic error, and should spam the console. > > BUG=695431 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2712033004 > Cr-Commit-Position: refs/heads/master@{#453019} > Committed: https://chromium.googlesource.com/chromium/src/+/7d39070d75082cd35a08775dd792d67cd2beeb40 TBR=enne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=695431 Review-Url: https://codereview.chromium.org/2799743005 Cr-Commit-Position: refs/heads/master@{#462646} Committed: https://chromium.googlesource.com/chromium/src/+/29e1187bcf8e4c2e9b322a0f7523fc627f5ef3b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M cc/output/program_binding.h View 3 chunks +5 lines, -8 lines 0 comments Download
M cc/output/program_binding.cc View 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ccameron
Created Revert of cc: Always log shader compiler errors
3 years, 8 months ago (2017-04-06 20:46:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799743005/1
3 years, 8 months ago (2017-04-06 20:47:48 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:18:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29e1187bcf8e4c2e9b322a0f7523...

Powered by Google App Engine
This is Rietveld 408576698