Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2799743004: Revert of Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests. (Closed)

Created:
2 years, 1 month ago by fdoray
Modified:
2 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests. (patchset #1 id:1 of https://codereview.chromium.org/2797293002/ ) Reason for revert: Test timeout in MutableProfileOAuth2TokenServiceDelegateTest.ShutdownService Original issue's description: > Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests. > > ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and > base/task_scheduler/post_task.h within its scope. It should be > instantiated in every unit test that uses either of these APIs > (i.e. no test should instantiate a MessageLoop directly). > > Motivation for ScopedTaskEnvironment can be found in: > https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit > > BUG=708584 > R=gab@chromium.org > TBR=sky@chromium.org, vitalybuka@chromium.org > > Review-Url: https://codereview.chromium.org/2797293002 > Cr-Commit-Position: refs/heads/master@{#462492} > Committed: https://chromium.googlesource.com/chromium/src/+/0bc320f205ad411a7ab935fa79879ff75e8a7fc9 TBR=gab@chromium.org,sky@chromium.org,vitalybuka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708584 Review-Url: https://codereview.chromium.org/2799743004 Cr-Commit-Position: refs/heads/master@{#462521} Committed: https://chromium.googlesource.com/chromium/src/+/320ae6a39b8d1d36cf65b82750942d957a029599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/chromeos/net/network_state_notifier_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/local_discovery/local_domain_resolver_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_notifications_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/utility/image_writer/image_writer_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fdoray
Created Revert of Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests.
2 years, 1 month ago (2017-04-06 17:14:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799743004/1
2 years, 1 month ago (2017-04-06 17:14:28 UTC) #3
commit-bot: I haz the power
2 years, 1 month ago (2017-04-06 17:16:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/320ae6a39b8d1d36cf65b8275094...

Powered by Google App Engine
This is Rietveld 408576698