Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: build/android/resource_sizes.py

Issue 2799743002: resource_sizes.py: Fix typo causing BuildId to not actually verify (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/resource_sizes.py
diff --git a/build/android/resource_sizes.py b/build/android/resource_sizes.py
index 89e7dca11a3453f01c61ba09e0c95601511f8534..b5a49b2a9f30a266ea93c399c44449eee7ffcc8e 100755
--- a/build/android/resource_sizes.py
+++ b/build/android/resource_sizes.py
@@ -160,7 +160,7 @@ def _CreateSectionNameSizeMap(so_path, tools_prefix):
def _ParseLibBuildId(so_path, tools_prefix):
"""Returns the Build ID of the given native library."""
- stdout = _RunReadelf(so_path, ['n'], tools_prefix)
+ stdout = _RunReadelf(so_path, ['-n'], tools_prefix)
match = re.search(r'Build ID: (\w+)', stdout)
return match.group(1) if match else None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698