Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2799653003: MD Bookmarks: Implement 'Sort by Title' menu button (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, arv+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Implement 'Sort by Title' menu button This button sorts the items in the current folder alphabetically, with folders before items. This CL also implements the onChildrenReordered event to handle the result of clicking the button, which is the final Bookmarks event to be implemented. BUG=708878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2799653003 Cr-Commit-Position: refs/heads/master@{#462433} Committed: https://chromium.googlesource.com/chromium/src/+/d3c31efdb084f2d6111cf5de1b91e2d485f883d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -20 lines) Patch
M chrome/browser/resources/md_bookmarks/actions.js View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/api_listener.js View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 2 chunks +33 lines, -19 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
tsergeant
⬆⬇
3 years, 8 months ago (2017-04-06 06:00:44 UTC) #3
calamity
lgtm
3 years, 8 months ago (2017-04-06 08:13:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799653003/1
3 years, 8 months ago (2017-04-06 10:52:49 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 11:56:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3c31efdb084f2d6111cf5de1b91...

Powered by Google App Engine
This is Rietveld 408576698