Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome/browser/resources/md_bookmarks/reducers.js

Issue 2799653003: MD Bookmarks: Implement 'Sort by Title' menu button (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/reducers.js
diff --git a/chrome/browser/resources/md_bookmarks/reducers.js b/chrome/browser/resources/md_bookmarks/reducers.js
index f361ce274bb087bb554ee4e07a4fbfb0beabc4dd..b5cfabe3c9bde4141b27aa4f5bedbffa8aa18112 100644
--- a/chrome/browser/resources/md_bookmarks/reducers.js
+++ b/chrome/browser/resources/md_bookmarks/reducers.js
@@ -204,23 +204,6 @@ cr.define('bookmarks', function() {
* @param {Action} action
* @return {NodeList}
*/
- NodeState.removeBookmark = function(nodes, action) {
- var newState =
- NodeState.modifyNode_(nodes, action.parentId, function(node) {
- var newChildren = node.children.slice();
- newChildren.splice(action.index, 1);
- return /** @type {BookmarkNode} */ (
- Object.assign({}, node, {children: newChildren}));
- });
-
- return bookmarks.util.removeIdsFromMap(newState, action.descendants);
- };
-
- /**
- * @param {NodeList} nodes
- * @param {Action} action
- * @return {NodeList}
- */
NodeState.moveBookmark = function(nodes, action) {
var nodeModifications = {};
var id = action.id;
@@ -253,16 +236,47 @@ cr.define('bookmarks', function() {
* @param {Action} action
* @return {NodeList}
*/
+ NodeState.removeBookmark = function(nodes, action) {
+ var newState =
+ NodeState.modifyNode_(nodes, action.parentId, function(node) {
+ var newChildren = node.children.slice();
+ newChildren.splice(action.index, 1);
+ return /** @type {BookmarkNode} */ (
+ Object.assign({}, node, {children: newChildren}));
+ });
+
+ return bookmarks.util.removeIdsFromMap(newState, action.descendants);
+ };
+
+ /**
+ * @param {NodeList} nodes
+ * @param {Action} action
+ * @return {NodeList}
+ */
+ NodeState.reorderChildren = function(nodes, action) {
+ return NodeState.modifyNode_(nodes, action.id, function(node) {
+ return /** @type {BookmarkNode} */ (
+ Object.assign({}, node, {children: action.children}));
+ });
+ };
+
+ /**
+ * @param {NodeList} nodes
+ * @param {Action} action
+ * @return {NodeList}
+ */
NodeState.updateNodes = function(nodes, action) {
switch (action.name) {
case 'create-bookmark':
return NodeState.createBookmark(nodes, action);
case 'edit-bookmark':
return NodeState.editBookmark(nodes, action);
- case 'remove-bookmark':
- return NodeState.removeBookmark(nodes, action);
case 'move-bookmark':
return NodeState.moveBookmark(nodes, action);
+ case 'remove-bookmark':
+ return NodeState.removeBookmark(nodes, action);
+ case 'reorder-children':
+ return NodeState.reorderChildren(nodes, action);
case 'refresh-nodes':
return action.nodes;
default:
« no previous file with comments | « chrome/browser/resources/md_bookmarks/compiled_resources2.gyp ('k') | chrome/browser/resources/md_bookmarks/toolbar.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698