Avoid status strings on successful ValueStore status.

Avoid status strings on successful ValueStore status.

ValueStore::Status mirrors a leveldb "Status" object which contains an error/success code and a string message.

LevelDB is carefully written so that an "OK" status does not have a message associated with it. But then in the Chrome ValueStore code the string is unconditionally retrieved (LevelDB maps this to "OK") and then expensive search-and-replace operations are performed on it.

This changes the levelDB "Status" to avoid the status string on "OK". This no-string-on-OK state is already implied by the Status header.

Review-Url: https://codereview.chromium.org/2799543002
Cr-Commit-Position: refs/heads/master@{#462734}
Committed: https://chromium.googlesource.com/chromium/src/+/5cba6a6eeb7463afbc2445f05914f26a66874454

[brettw, 2017-04-05 00:58:32]

brettw@chromium.org changed reviewers:
+ cmumford@chromium.org

[brettw, 2017-04-05 00:59:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 01:00:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 01:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:48:35]

Dry run: This issue passed the CQ dry run.

[cmumford, 2017-04-06 23:15:32]

lgtm

[brettw, 2017-04-06 23:17:49]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 01:27:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491520669978330, "parent_rev":
"7131c1fee08ad62e85476acfd3604765bc997f39", "commit_rev":
"5cba6a6eeb7463afbc2445f05914f26a66874454"}

[commit-bot: I haz the power, 2017-04-07 01:28:27]

Description was changed from

==========
Avoid status strings on successful ValueStore status.

ValueStore::Status mirrors a leveldb "Status" object which contains an
error/success code and a string message.

LevelDB is carefully written so that an "OK" status does not have a message
associated with it. But then in the Chrome ValueStore code the string is
unconditionally retrieved (LevelDB maps this to "OK") and then expensive
search-and-replace operations are performed on it.

This changes the levelDB "Status" to avoid the status string on "OK". This
no-string-on-OK state is already implied by the Status header.
==========

to

==========
Avoid status strings on successful ValueStore status.

ValueStore::Status mirrors a leveldb "Status" object which contains an
error/success code and a string message.

LevelDB is carefully written so that an "OK" status does not have a message
associated with it. But then in the Chrome ValueStore code the string is
unconditionally retrieved (LevelDB maps this to "OK") and then expensive
search-and-replace operations are performed on it.

This changes the levelDB "Status" to avoid the status string on "OK". This
no-string-on-OK state is already implied by the Status header.

Review-Url: https://codereview.chromium.org/2799543002
Cr-Commit-Position: refs/heads/master@{#462734}
Committed:
https://chromium.googlesource.com/chromium/src/+/5cba6a6eeb7463afbc2445f05914...
==========

[commit-bot: I haz the power, 2017-04-07 01:28:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5cba6a6eeb7463afbc2445f05914...