Avoid status strings on successful ValueStore status.

extensions/browser/value_store/lazy_leveldb.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/value_store/lazy_leveldb.h"
 
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
@@ skipping 235 matching lines @@
       status.code = ValueStore::OK;
       status.message = kRestoredDuringOpen;
     }
   }
 
   return status;
 }
 
 ValueStore::Status LazyLevelDb::ToValueStoreError(
     const leveldb::Status& status) {
+  if (status.ok())
+    return ValueStore::Status();
+
   CHECK(!status.IsNotFound());  // not an error
 
   std::string message = status.ToString();
   // The message may contain |db_path_|, which may be considered sensitive
   // data, and those strings are passed to the extension, so strip it out.
   base::ReplaceSubstringsAfterOffset(&message, 0u, db_path_.AsUTF8Unsafe(),
                                      "...");
 
   return ValueStore::Status(LevelDbToValueStoreStatusCode(status), message);
 }
@@ skipping 10 matching lines @@
 
 ValueStore::Status LazyLevelDb::CreateIterator(
     const leveldb::ReadOptions& read_options,
     std::unique_ptr<leveldb::Iterator>* iterator) {
   ValueStore::Status status = EnsureDbIsOpen();
   if (!status.ok())
     return status;
   *iterator = base::WrapUnique(db_->NewIterator(read_options));
   return ValueStore::Status();
 }