DevTools: Only detach FilteredListWidget dialog after item is selected

DevTools: Only detach FilteredListWidget dialog after item is selected

The dialog was hidden, which caused the provider to detached. Then
selectItem was called on the provider, which was in a potentially
bad state.

BUG=662081
Review-Url: https://codereview.chromium.org/2799483003
Cr-Commit-Position: refs/heads/master@{#461959}
Committed: https://chromium.googlesource.com/chromium/src/+/b638cb237c9a6a1ae7d360ec721b77381c4dbe3b

[einbinder, 2017-04-04 23:46:20]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2017-04-04 23:46:20]

ptal

I used the manual test plan to verify that this doesn't regress focus.

[pfeldman, 2017-04-04 23:47:58]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2017-04-04 23:47:58]

lgtm

[einbinder, 2017-04-05 00:10:01]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-05 00:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:57:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491351001889720, "parent_rev":
"9e5df82b734aaf9c6dc37646acf0791737b55c70", "commit_rev":
"b638cb237c9a6a1ae7d360ec721b77381c4dbe3b"}

[commit-bot: I haz the power, 2017-04-05 02:58:35]

Description was changed from

==========
DevTools: Only detach FilteredListWidget dialog after item is selected

The dialog was hidden, which caused the provider to detached. Then
selectItem was called on the provider, which was in a potentially
bad state.

BUG=662081
==========

to

==========
DevTools: Only detach FilteredListWidget dialog after item is selected

The dialog was hidden, which caused the provider to detached. Then
selectItem was called on the provider, which was in a potentially
bad state.

BUG=662081

Review-Url: https://codereview.chromium.org/2799483003
Cr-Commit-Position: refs/heads/master@{#461959}
Committed:
https://chromium.googlesource.com/chromium/src/+/b638cb237c9a6a1ae7d360ec721b...
==========

[commit-bot: I haz the power, 2017-04-05 02:58:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b638cb237c9a6a1ae7d360ec721b...

[dgozman, 2017-04-05 15:39:25]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-04-05 15:39:25]

https://codereview.chromium.org/2799483003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
(left):

https://codereview.chromium.org/2799483003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js:278:
// Detach dialog before allowing provider to override focus.
Note this was done on purpose. What happens with focus now?