third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js - Issue 2799483003: DevTools: Only detach FilteredListWidget dialog after item is selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

Issue 2799483003: DevTools: Only detach FilteredListWidget dialog after item is selected (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

index 2d598c4753b421e367a1c9689d8f0b22eb1e4a3f..191da2a7fb617600a2d4d5d79c456a317efd6490 100644

--- a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

@@ -198,10 +198,9 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

return;

var selectedIndexInProvider = this._provider.itemCount() ? this._list.selectedItem() : null;

- // Detach dialog before allowing provider to override focus.

+ this._selectItem(selectedIndexInProvider);

if (this._dialog)

this._dialog.hide();

- this._selectItem(selectedIndexInProvider);

}

/**

@@ -275,10 +274,9 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

return;

event.consume(true);

- // Detach dialog before allowing provider to override focus.

dgozman 2017/04/05 15:39:25 Note this was done on purpose. What happens with f

+ this._selectItem(item);

if (this._dialog)

this._dialog.hide();

- this._selectItem(item);

}

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »