Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2799413002: Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI. (Closed)
Patch Set: Fix tests broken from rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index a1e12cfb4a719699e787889d5485f5da85d60c00..4b2be9c423c71d622f9f49202e64fd40deb0bec8 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -2785,10 +2785,8 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
return GetState(browserAccessibility_, ui::AX_STATE_FOCUSABLE);
}
- if ([attribute isEqualToString:NSAccessibilityValueAttribute]) {
- return browserAccessibility_->GetBoolAttribute(
- ui::AX_ATTR_CAN_SET_VALUE);
- }
+ if ([attribute isEqualToString:NSAccessibilityValueAttribute])
+ return browserAccessibility_->HasAction(ui::AX_ACTION_SET_VALUE);
dmazzoni 2017/05/19 19:24:25 Love it, this is a lot cleaner!
Patti Lor 2017/05/22 00:20:59 Yay :)
if ([attribute isEqualToString:NSAccessibilitySelectedTextRangeAttribute] &&
browserAccessibility_->HasState(ui::AX_STATE_EDITABLE)) {
« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_com_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698