Restore BLUETOOTH_LOG and convert bluetooth_adapter_bluez to use it

Restore BLUETOOTH_LOG and convert bluetooth_adapter_bluez to use it

In https://codereview.chromium.org/2659843004 we removed
BLUETOOTH_LOG because it was unused.

We have yet to replace it with anything (as near as i can tell) and I
need to start tracking events so that I can debug the Settings UI.

For now the events will appear in chrome://device-log because it is
easy, however it would be very easy to use the results in the
bluetooth-internals page, e.g.:

device_event_log::GetAsString(OLDEST_FIRST, "json", "bluetooth", ...);

Note: We already use device_event_log in device/usb and device/hid.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2799353002
Cr-Commit-Position: refs/heads/master@{#463072}
Committed: https://chromium.googlesource.com/chromium/src/+/61c37ed899d755505e5243d8d87e5aa98d78328b

[stevenjb, 2017-04-06 23:31:33]

Description was changed from

==========
Restore BLUETOOTH_LOG and convert bluetooth_adapter_bluez to use it

In https://codereview.chromium.org/2659843004 we removed
BLUETOOTH_LOG because it was unused.

We have yet to replace it with anything (as near as i can tell) and I
need to start tracking events so that I can debug the Settings UI.

For now the events will appear in chrome://device-log because it is
easy, however it would be very easy to use the results in the
bluetooth-internals page, e.g.:

device_event_log::GetAsString(OLDEST_FIRST, "json", "bluetooth", ...);

Note: We already use device_event_log in device/usb and device/hid.

BUG=none
==========

to

==========
Restore BLUETOOTH_LOG and convert bluetooth_adapter_bluez to use it

In https://codereview.chromium.org/2659843004 we removed
BLUETOOTH_LOG because it was unused.

We have yet to replace it with anything (as near as i can tell) and I
need to start tracking events so that I can debug the Settings UI.

For now the events will appear in chrome://device-log because it is
easy, however it would be very easy to use the results in the
bluetooth-internals page, e.g.:

device_event_log::GetAsString(OLDEST_FIRST, "json", "bluetooth", ...);

Note: We already use device_event_log in device/usb and device/hid.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-06 23:32:43]

stevenjb@chromium.org changed reviewers:
+ rkc@chromium.org, scheib@chromium.org

[scheib, 2017-04-07 00:19:29]

LGTM, but:

When looking at LOG -> DEVICE_LOG changes I thought "does DEVICE_LOG pass
through to the normal logging system?" This seems to be true, but would you make
it clear at the top level comments here:
https://cs.chromium.org/chromium/src/components/device_event_log/device_event...
(or better, move those comments to a README.md)

[stevenjb, 2017-04-07 17:57:26]

On 2017/04/07 00:19:29, scheib wrote:
> LGTM, but:
> 
> When looking at LOG -> DEVICE_LOG changes I thought "does DEVICE_LOG pass
> through to the normal logging system?" This seems to be true, but would you
make
> it clear at the top level comments here:
>
https://cs.chromium.org/chromium/src/components/device_event_log/device_event...
> (or better, move those comments to a README.md)

Good suggestion, I added a README.md (and caught and fixed a bug in the
filtering while documenting :) )

[stevenjb, 2017-04-07 17:57:35]

PTAL

[rkc, 2017-04-07 20:16:41]

Any particular reason why we are only converting bluetooth_adapter to use this?

If we want to focus only on device level logs, we should probably do both
bluetooth_adapter and bluetooth_device.

https://codereview.chromium.org/2799353002/diff/40001/components/device_event...
File components/device_event_log/README.md (right):

https://codereview.chromium.org/2799353002/diff/40001/components/device_event...
components/device_event_log/README.md:34: ```POWER_LOG(DEBUG) << "Sending
suspent request to dbus object: " << path;```
nit: s/suspent/suspend

[stevenjb, 2017-04-07 21:00:25]

In general I add / convert logging as needed, but I went ahead and converted
bluetooth_device_bluez since I think it makes sense to do that here.

PTAL

[rkc, 2017-04-07 21:04:26]

lgtm

[stevenjb, 2017-04-07 21:11:05]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 21:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:27:10]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[stevenjb, 2017-04-07 21:38:58]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:39:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:17:13]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-04-07 23:24:44]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-07 23:24:44]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
rkc@chromium.org
Link to the patchset: https://codereview.chromium.org/2799353002/#ps100001
(title: "Fix BUILD.gn")

[commit-bot: I haz the power, 2017-04-07 23:25:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 00:27:54]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491607484087380,
"parent_rev": "3b7e3fac6988ecb6dd1d2465aee41e473724c9d2", "commit_rev":
"61c37ed899d755505e5243d8d87e5aa98d78328b"}

[commit-bot: I haz the power, 2017-04-08 00:29:44]

Description was changed from

==========
Restore BLUETOOTH_LOG and convert bluetooth_adapter_bluez to use it

In https://codereview.chromium.org/2659843004 we removed
BLUETOOTH_LOG because it was unused.

We have yet to replace it with anything (as near as i can tell) and I
need to start tracking events so that I can debug the Settings UI.

For now the events will appear in chrome://device-log because it is
easy, however it would be very easy to use the results in the
bluetooth-internals page, e.g.:

device_event_log::GetAsString(OLDEST_FIRST, "json", "bluetooth", ...);

Note: We already use device_event_log in device/usb and device/hid.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Restore BLUETOOTH_LOG and convert bluetooth_adapter_bluez to use it

In https://codereview.chromium.org/2659843004 we removed
BLUETOOTH_LOG because it was unused.

We have yet to replace it with anything (as near as i can tell) and I
need to start tracking events so that I can debug the Settings UI.

For now the events will appear in chrome://device-log because it is
easy, however it would be very easy to use the results in the
bluetooth-internals page, e.g.:

device_event_log::GetAsString(OLDEST_FIRST, "json", "bluetooth", ...);

Note: We already use device_event_log in device/usb and device/hid.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2799353002
Cr-Commit-Position: refs/heads/master@{#463072}
Committed:
https://chromium.googlesource.com/chromium/src/+/61c37ed899d755505e5243d8d87e...
==========

[commit-bot: I haz the power, 2017-04-08 00:29:45]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/61c37ed899d755505e5243d8d87e...