Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2659843004: Remove BLUETOOTH_LOG from chrome://device-log. (Closed)

Created:
3 years, 10 months ago by scheib
Modified:
3 years, 10 months ago
Reviewers:
ortuno, stevenjb
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BLUETOOTH_LOG from chrome://device-log. Work stalled adding Bluetooth logs to this area. There were also concerns about how much verbosity to include. We not have chrome://bluetooth-internals, and while we'll need to build up some infrastructure to send logs there, it will be the more appropriate place. BUG=516825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2659843004 Cr-Commit-Position: refs/heads/master@{#447019} Committed: https://chromium.googlesource.com/chromium/src/+/72a84c1c823e0f4eedb24a21a387f0bd5c2907e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/device_log_ui/device_log_ui.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/device_log_ui/device_log_ui.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/device_log_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/device_event_log/device_event_log.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
scheib
3 years, 10 months ago (2017-01-27 17:35:52 UTC) #5
ortuno
lgtm
3 years, 10 months ago (2017-01-27 21:43:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659843004/1
3 years, 10 months ago (2017-01-28 01:30:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352741)
3 years, 10 months ago (2017-01-28 01:39:30 UTC) #12
scheib
stevenjb, owners for device UI please.
3 years, 10 months ago (2017-01-28 16:17:27 UTC) #14
stevenjb
It seems a shame to me to remove this, it would be easy enough to ...
3 years, 10 months ago (2017-01-30 17:21:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659843004/1
3 years, 10 months ago (2017-01-30 17:37:31 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:42:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72a84c1c823e0f4eedb24a21a387...

Powered by Google App Engine
This is Rietveld 408576698