Add support for native extension notifications

chrome/browser/extensions/api/notifications/notifications_api.cc

Index: chrome/browser/extensions/api/notifications/notifications_api.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc
index c69c831c85726a36110404d8906c66d054560183..7bbfc31bffef5c4fd4fee3d2b755b72c4be00d10 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc
@@ -443,6 +443,8 @@ bool NotificationsApiFunction::CreateNotification(
   if (options->context_message) {
     optional_fields.context_message =
         base::UTF8ToUTF16(*options->context_message);
+  } else {
+    optional_fields.context_message = base::UTF8ToUTF16("");

[Peter Beverloo, 2017/04/07 02:26:53]

Why is this necessary? I think this is a no-op? It's a base::string16 member so
it should be initialized as the empty string.

If we really need to initialize it, you could use base::EmptyString16(), but I'm
sceptical.

[Miguel Garcia, 2017/04/07 13:32:06]

You are right, it was not needed.

   }
 
   bool has_image = options->image_bitmap.get() &&
@@ -584,6 +586,8 @@ bool NotificationsApiFunction::UpdateNotification(
   if (options->context_message) {
     notification->set_context_message(
         base::UTF8ToUTF16(*options->context_message));
+  } else {
+    notification->set_context_message(base::UTF8ToUTF16(""));

[Peter Beverloo, 2017/04/07 02:26:53]

(dito)

[Miguel Garcia, 2017/04/07 13:32:06]

Acknowledged.

   }
 
   gfx::Image image;