Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.cc

Issue 2799343003: Add support for native extension notifications (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/extension_notification_handler.cc
diff --git a/chrome/browser/extensions/api/notifications/extension_notification_handler.cc b/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
index 84cf00ea30ec12a95f003b0eb61a7fdb35f4bfec..31f1641928849b4a7346247d2130b52f6c067657 100644
--- a/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
+++ b/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
@@ -4,32 +4,12 @@
#include "chrome/browser/extensions/api/notifications/extension_notification_handler.h"
-#include "base/logging.h"
-
-ExtensionNotificationHandler::ExtensionNotificationHandler() = default;
+ExtensionNotificationHandler::ExtensionNotificationHandler()
+ : NonPersistentNotificationHandler() {}
ExtensionNotificationHandler::~ExtensionNotificationHandler() = default;
-void ExtensionNotificationHandler::OnClose(Profile* profile,
- const std::string& origin,
- const std::string& notification_id,
- bool by_user) {
- // TODO(peter): Call EraseDataForNotificationId from here once this event
- // can be relied upon. (It's only been implemented for native NDSes.)
-}
-
-void ExtensionNotificationHandler::OnClick(
- Profile* profile,
- const std::string& origin,
- const std::string& notification_id,
- int action_index,
- const base::NullableString16& reply) {}
-
void ExtensionNotificationHandler::OpenSettings(Profile* profile) {
// Extension notifications don't display a settings button.
NOTREACHED();
}
-
-void ExtensionNotificationHandler::RegisterNotification(
- const std::string& notification_id,
- NotificationDelegate* delegate) {}

Powered by Google App Engine
This is Rietveld 408576698