Add support for native extension notifications

chrome/browser/extensions/api/notifications/notifications_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 425 matching lines @@
             image_scale, bitmap_sizes.button_icon_size, *icon_bitmap_ptr,
             &info.icon);
       }
       optional_fields.buttons.push_back(info);
     }
   }
 
   if (options->context_message) {
     optional_fields.context_message =
         base::UTF8ToUTF16(*options->context_message);
+  } else {
+    optional_fields.context_message = base::UTF8ToUTF16("");

[Peter Beverloo, 2017/04/07 02:26:53]

Why is this necessary? I think this is a no-op? It's a base::string16 member so
it should be initialized as the empty string.

If we really need to initialize it, you could use base::EmptyString16(), but I'm
sceptical.

[Miguel Garcia, 2017/04/07 13:32:06]

You are right, it was not needed.

   }
 
   bool has_image = options->image_bitmap.get() &&
                    NotificationBitmapToGfxImage(
                        image_scale, bitmap_sizes.image_size,
                        *options->image_bitmap, &optional_fields.image);
 
   // We should have an image if and only if the type is an image type.
   if (has_image != (type == message_center::NOTIFICATION_TYPE_IMAGE)) {
     SetError(kExtraImageProvided);
@@ skipping 121 matching lines @@
             &button.icon);
       }
       buttons.push_back(button);
     }
     notification->set_buttons(buttons);
   }
 
   if (options->context_message) {
     notification->set_context_message(
         base::UTF8ToUTF16(*options->context_message));
+  } else {
+    notification->set_context_message(base::UTF8ToUTF16(""));

[Peter Beverloo, 2017/04/07 02:26:53]

(dito)

[Miguel Garcia, 2017/04/07 13:32:06]

Acknowledged.

   }
 
   gfx::Image image;
   bool has_image =
       options->image_bitmap.get() &&
       NotificationBitmapToGfxImage(
           image_scale, bitmap_sizes.image_size, *options->image_bitmap, &image);
 
   if (has_image) {
     // We should have an image if and only if the type is an image type.
@@ skipping 231 matching lines @@
           : api::notifications::PERMISSION_LEVEL_DENIED;
 
   SetResult(
       base::MakeUnique<base::Value>(api::notifications::ToString(result)));
   SendResponse(true);
 
   return true;
 }
 
 }  // namespace extensions