Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.h

Issue 2799343003: Add support for native extension notifications (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/extension_notification_handler.h
diff --git a/chrome/browser/extensions/api/notifications/extension_notification_handler.h b/chrome/browser/extensions/api/notifications/extension_notification_handler.h
index 7041755ff6d78671bf4f82f1cca87724d3e7806e..ee22ce218c55beb584f1637791ebefd25a42af21 100644
--- a/chrome/browser/extensions/api/notifications/extension_notification_handler.h
+++ b/chrome/browser/extensions/api/notifications/extension_notification_handler.h
@@ -6,28 +6,16 @@
#define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_
#include "base/macros.h"
-#include "chrome/browser/notifications/notification_handler.h"
+#include "chrome/browser/notifications/non_persistent_notification_handler.h"
// Handler for notifications shown by extensions. Will be created and owned by
// the NotificationDisplayService.
-class ExtensionNotificationHandler : public NotificationHandler {
+class ExtensionNotificationHandler : public NonPersistentNotificationHandler {
Peter Beverloo 2017/04/07 02:26:53 Hmm. I like the idea of reasoning about extension
Miguel Garcia 2017/04/07 13:32:06 Acknowledged.
public:
ExtensionNotificationHandler();
~ExtensionNotificationHandler() override;
- // NotificationHandler implementation.
- void OnClose(Profile* profile,
- const std::string& origin,
- const std::string& notification_id,
- bool by_user) override;
- void OnClick(Profile* profile,
- const std::string& origin,
- const std::string& notification_id,
- int action_index,
- const base::NullableString16& reply) override;
void OpenSettings(Profile* profile) override;
- void RegisterNotification(const std::string& notification_id,
- NotificationDelegate* delegate) override;
private:
DISALLOW_COPY_AND_ASSIGN(ExtensionNotificationHandler);

Powered by Google App Engine
This is Rietveld 408576698