Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2799253002: Switch from TestBrowserThread to TestBrowserThreadBundle in components. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch from TestBrowserThread to TestBrowserThreadBundle in components. TestBrowserThread is deprecated. TestBrowserThreadBundle provides all browser threads, a blocking pool and a TaskScheduler. This CL was generated using the script posted on the bug + git cl format + tools/sort-headers.py + some manual adjustments. BUG=272091 R=gab@chromium.org TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2799253002 Cr-Commit-Position: refs/heads/master@{#462839} Committed: https://chromium.googlesource.com/chromium/src/+/d672606e5db906db421e0dd87703f53788dbfffa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M components/feedback/feedback_data_unittest.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M components/feedback/feedback_uploader_unittest.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M components/web_cache/browser/web_cache_manager_unittest.cc View 3 chunks +3 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
fdoray
3 years, 8 months ago (2017-04-06 13:12:54 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to owners.
3 years, 8 months ago (2017-04-06 13:12:57 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-07 06:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799253002/1
3 years, 8 months ago (2017-04-07 11:44:38 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 11:50:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d672606e5db906db421e0dd87703...

Powered by Google App Engine
This is Rietveld 408576698