Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1871)

Unified Diff: components/feedback/feedback_data_unittest.cc

Issue 2799253002: Switch from TestBrowserThread to TestBrowserThreadBundle in components. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/feedback/feedback_uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/feedback/feedback_data_unittest.cc
diff --git a/components/feedback/feedback_data_unittest.cc b/components/feedback/feedback_data_unittest.cc
index c41e0724080084438cabbd079da88a399f4b3989..d6e353b398ec563f561dd1d12d4cff5fe4b7be1c 100644
--- a/components/feedback/feedback_data_unittest.cc
+++ b/components/feedback/feedback_data_unittest.cc
@@ -9,7 +9,6 @@
#include <utility>
#include "base/memory/ptr_util.h"
-#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "components/feedback/feedback_uploader.h"
#include "components/feedback/feedback_uploader_factory.h"
@@ -18,6 +17,7 @@
#include "components/user_prefs/user_prefs.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -58,8 +58,7 @@ class FeedbackDataTest : public testing::Test {
FeedbackDataTest()
: context_(new content::TestBrowserContext()),
prefs_(new TestingPrefServiceSimple()),
- data_(new FeedbackData()),
- ui_thread_(content::BrowserThread::UI, &message_loop_) {
+ data_(new FeedbackData()) {
user_prefs::UserPrefs::Set(context_.get(), prefs_.get());
data_->set_context(context_.get());
data_->set_send_report_callback(base::Bind(
@@ -95,8 +94,7 @@ class FeedbackDataTest : public testing::Test {
std::unique_ptr<content::TestBrowserContext> context_;
std::unique_ptr<PrefService> prefs_;
scoped_refptr<FeedbackData> data_;
- base::MessageLoop message_loop_;
- content::TestBrowserThread ui_thread_;
+ content::TestBrowserThreadBundle test_browser_thread_bundle_;
};
TEST_F(FeedbackDataTest, ReportSending) {
« no previous file with comments | « no previous file | components/feedback/feedback_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698