Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2799183002: Add UMA histogram about what format of swapchain is created for overlays (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
Reviewers:
sunnyps, Ilya Sherman
CC:
chromium-reviews, piman+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA histogram about what format of swapchain is created for overlays Ideally this should be YUY2, but we have a fallback to B8G8R8A8 and should check that it's being used at most very rarely. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2799183002 Cr-Commit-Position: refs/heads/master@{#462738} Committed: https://chromium.googlesource.com/chromium/src/+/6280d0d289acfba30fbac97d549dc3e029b6c198

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
jbauman
3 years, 8 months ago (2017-04-06 03:00:35 UTC) #5
sunnyps
lgtm
3 years, 8 months ago (2017-04-06 03:56:14 UTC) #6
jbauman
3 years, 8 months ago (2017-04-06 18:43:52 UTC) #10
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-06 22:04:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799183002/1
3 years, 8 months ago (2017-04-06 22:23:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/404890)
3 years, 8 months ago (2017-04-06 22:41:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799183002/20001
3 years, 8 months ago (2017-04-06 23:28:29 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/188995)
3 years, 8 months ago (2017-04-07 00:44:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799183002/20001
3 years, 8 months ago (2017-04-07 01:03:22 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:37:00 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6280d0d289acfba30fbac97d549d...

Powered by Google App Engine
This is Rietveld 408576698