Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Issue 2799153005: REVERT: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
Reviewers:
junwei
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, agrieve+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, darin-cc_chromium.org, mac-reviews_chromium.org, blink-reviews, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

REVERT: ShapeDetection: use mojom::Bitmap for mojo interface. This CL reverts two landed CLs, namely: https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59 https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8 (reviewed in https://crrev.com/2771703002 and https://crrev.com/2765723002, resp.), because they seemed to have introduced a flake in the associated LayoutTests. TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org BUG=665488, 707689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2799153005 Cr-Commit-Position: refs/heads/master@{#462639} Committed: https://chromium.googlesource.com/chromium/src/+/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -166 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java View 4 chunks +6 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java View 4 chunks +6 lines, -16 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java View 2 chunks +10 lines, -22 lines 0 comments Download
M services/shape_detection/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M services/shape_detection/barcode_detection_impl_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/shape_detection/barcode_detection_impl_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M services/shape_detection/barcode_detection_impl_mac_unittest.mm View 3 chunks +19 lines, -5 lines 0 comments Download
M services/shape_detection/detection_utils_mac.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/shape_detection/detection_utils_mac.mm View 1 chunk +42 lines, -12 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac_unittest.mm View 1 chunk +14 lines, -2 lines 0 comments Download
M services/shape_detection/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/shape_detection/public/interfaces/barcodedetection.mojom View 2 chunks +4 lines, -3 lines 0 comments Download
M services/shape_detection/public/interfaces/facedetection.mojom View 2 chunks +4 lines, -3 lines 0 comments Download
M services/shape_detection/public/interfaces/textdetection.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shape_detection/text_detection_impl_mac.h View 1 chunk +3 lines, -1 line 0 comments Download
M services/shape_detection/text_detection_impl_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M services/shape_detection/text_detection_impl_mac_unittest.mm View 2 chunks +18 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 5 chunks +56 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799153005/1
3 years, 8 months ago (2017-04-06 21:11:05 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:00:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f2e5dcdcecc501ddf56396c2846...

Powered by Google App Engine
This is Rietveld 408576698