third_party/WebKit/Source/modules/shapedetection/FaceDetector.h - Issue 2799153005: REVERT: ShapeDetection: use mojom::Bitmap for mojo interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/shapedetection/FaceDetector.h

Issue 2799153005: REVERT: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/shapedetection/FaceDetector.h

diff --git a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h

index 2047879c07eb714f616fb18dfb567b05c00b601e..84f6b9fba86d9e6b30153d9e4f432262099652b2 100644

--- a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h

+++ b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h

@@ -31,7 +31,9 @@ class MODULES_EXPORT FaceDetector final : public ShapeDetector,

~FaceDetector() override = default;

ScriptPromise doDetect(ScriptPromiseResolver*,

- skia::mojom::blink::BitmapPtr) override;

+ mojo::ScopedSharedBufferHandle,

+ int imageWidth,

+ int imageHeight) override;

void onDetectFaces(ScriptPromiseResolver*,

shape_detection::mojom::blink::FaceDetectionResultPtr);

void onFaceServiceConnectionError();