enhance analyzer to parse uppercase and built-in/pseudo keywords

enhance analyzer to parse uppercase and built-in/pseudo keywords

Retrying https://codereview.chromium.org/2803563003

* update analyzer.Keyword list to include all of the fasta keywords

* enhance the analyzer scanner keyword table to handle uppercase
  keywords such as "Function"

* update analyzer's parser to process the new KeywordTokens

* fix analyzer error verification

* update translation of fasta <--> analyzer tokens

* update tests and cleanup analyzer warnings

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b8a2eb03b0b8f1914b1883382224036bb456c64

[danrubel, 2017-04-06 14:29:40]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-04-06 17:09:49]

lgtm.

For future reference, when making a second attempt to land a CL, it is really
helpful if you can upload two patches: one which is the CL in its
previously-landed form, and one which is the new form you want reviewed.  That
way we can see what has changed since last time :)

https://codereview.chromium.org/2799133003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2799133003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:2630: if (token.type ==
TokenType.KEYWORD && token.keyword?.isPseudo != true) {
Since token.keyword is non-null if and only if token.type == TokenType.KEYWORD,
I think we could simplify this to:

if (token.keyword?.isPseudo != true)

[danrubel, 2017-04-06 19:21:35]

> For future reference, when making a second attempt to land a CL, it is really
> helpful if you can upload two patches: one which is the CL in its
> previously-landed form, and one which is the new form you want reviewed.  That
> way we can see what has changed since last time :)

Ah. Good point. Will do that next time this happens.

https://codereview.chromium.org/2799133003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2799133003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:2630: if (token.type ==
TokenType.KEYWORD && token.keyword?.isPseudo != true) {
On 2017/04/06 17:09:49, Paul Berry wrote:
> Since token.keyword is non-null if and only if token.type ==
TokenType.KEYWORD,
> I think we could simplify this to:
> 
> if (token.keyword?.isPseudo != true)

Unfortunately that change will report errors on any token that returns a null
keyword, such as all identifiers. That said, you have a good point that this
expression could probably be simplified.

[danrubel, 2017-04-06 19:24:59]

Description was changed from

==========
enhance analyzer to parse uppercase and built-in/pseudo keywords

Retrying https://codereview.chromium.org/2803563003

* update analyzer.Keyword list to include all of the fasta keywords

* enhance the analyzer scanner keyword table to handle uppercase
  keywords such as "Function"

* update analyzer's parser to process the new KeywordTokens

* fix analyzer error verification

* update translation of fasta <--> analyzer tokens

* update tests and cleanup analyzer warnings
==========

to

==========
enhance analyzer to parse uppercase and built-in/pseudo keywords

Retrying https://codereview.chromium.org/2803563003

* update analyzer.Keyword list to include all of the fasta keywords

* enhance the analyzer scanner keyword table to handle uppercase
  keywords such as "Function"

* update analyzer's parser to process the new KeywordTokens

* fix analyzer error verification

* update translation of fasta <--> analyzer tokens

* update tests and cleanup analyzer warnings

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b8a2eb03b0b8f1914b1883382224036bb456c64
==========

[danrubel, 2017-04-06 19:25:00]

Committed patchset #1 (id:1) manually as
4b8a2eb03b0b8f1914b1883382224036bb456c64 (presubmit successful).

[ahe, 2017-05-31 14:12:38]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-05-31 14:12:39]

lgtm