enhance analyzer to parse uppercase and built-in/pseudo keywords

pkg/analyzer/lib/src/generated/error_verifier.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.error_verifier;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 2609 matching lines @@
    * Verify that the given [identifier] is not a keyword, and generates the
    * given [errorCode] on the identifier if it is a keyword.
    *
    * See [CompileTimeErrorCode.BUILT_IN_IDENTIFIER_AS_TYPE_NAME],
    * [CompileTimeErrorCode.BUILT_IN_IDENTIFIER_AS_TYPE_PARAMETER_NAME], and
    * [CompileTimeErrorCode.BUILT_IN_IDENTIFIER_AS_TYPEDEF_NAME].
    */
   void _checkForBuiltInIdentifierAsName(
       SimpleIdentifier identifier, ErrorCode errorCode) {
     Token token = identifier.token;
-    if (token.type == TokenType.KEYWORD) {
+    if (token.type == TokenType.KEYWORD && token.keyword?.isPseudo != true) {

[Paul Berry, 2017/04/06 17:09:49]

Since token.keyword is non-null if and only if token.type == TokenType.KEYWORD,
I think we could simplify this to:

if (token.keyword?.isPseudo != true)

[danrubel, 2017/04/06 19:21:35]

Unfortunately that change will report errors on any token that returns a null
keyword, such as all identifiers. That said, you have a good point that this
expression could probably be simplified.

       _errorReporter
           .reportErrorForNode(errorCode, identifier, [identifier.name]);
     }
   }
 
   /**
    * Verify that the given [switchCase] is terminated with 'break', 'continue',
    * 'return' or 'throw'.
    *
    * see [StaticWarningCode.CASE_BLOCK_NOT_TERMINATED].
@@ skipping 4518 matching lines @@
 class _InvocationCollector extends RecursiveAstVisitor {
   final List<String> superCalls = <String>[];
 
   @override
   visitMethodInvocation(MethodInvocation node) {
     if (node.target is SuperExpression) {
       superCalls.add(node.methodName.name);
     }
   }
 }