Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2803563003: enhance analyzer to parse uppercase and built-in/pseudo keywords (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

enhance analyzer to parse uppercase and built-in/pseudo keywords * update analyzer.Keyword list to include all of the fasta keywords * enhance the analyzer scanner keyword table to handle uppercase keywords such as "Function" * update analyzer's parser to process the new KeywordTokens R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/0c9e871b0fc188c44549227f4f39bbcbccb4fa76

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -49 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 16 chunks +30 lines, -34 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 7 chunks +13 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 7 chunks +38 lines, -0 lines 0 comments Download
M pkg/front_end/test/token_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 8 months ago (2017-04-05 18:00:27 UTC) #2
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-05 18:09:46 UTC) #3
danrubel
3 years, 8 months ago (2017-04-05 20:37:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c9e871b0fc188c44549227f4f39bbcbccb4fa76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698