Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: base/BUILD.gn

Issue 2799123002: Remove allow_circular_includes_from from base/BUILD.gn (Closed)
Patch Set: Remove allow_circular_includes_from from base/BUILD.gn Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1600 matching lines...) Expand 10 before | Expand all | Expand 10 after
1611 } else { 1611 } else {
1612 data += [ "//third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer" ] 1612 data += [ "//third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer" ]
1613 } 1613 }
1614 } 1614 }
1615 1615
1616 configs += [ "//build/config/compiler:wexit_time_destructors" ] 1616 configs += [ "//build/config/compiler:wexit_time_destructors" ]
1617 if (!is_debug) { 1617 if (!is_debug) {
1618 configs -= [ "//build/config/compiler:default_optimization" ] 1618 configs -= [ "//build/config/compiler:default_optimization" ]
1619 configs += [ "//build/config/compiler:optimize_max" ] 1619 configs += [ "//build/config/compiler:optimize_max" ]
1620 } 1620 }
1621
1622 allow_circular_includes_from = public_deps
1623 } 1621 }
1624 1622
1625 buildflag_header("debugging_flags") { 1623 buildflag_header("debugging_flags") {
1626 header = "debugging_flags.h" 1624 header = "debugging_flags.h"
1627 header_dir = "base/debug" 1625 header_dir = "base/debug"
1628 flags = [ 1626 flags = [
1629 "ENABLE_PROFILING=$enable_profiling", 1627 "ENABLE_PROFILING=$enable_profiling",
1630 "ENABLE_MEMORY_TASK_PROFILER=$enable_memory_task_profiler", 1628 "ENABLE_MEMORY_TASK_PROFILER=$enable_memory_task_profiler",
1631 ] 1629 ]
1632 } 1630 }
(...skipping 1055 matching lines...) Expand 10 before | Expand all | Expand 10 after
2688 } 2686 }
2689 2687
2690 fuzzer_test("base_json_correctness_fuzzer") { 2688 fuzzer_test("base_json_correctness_fuzzer") {
2691 sources = [ 2689 sources = [
2692 "json/correctness_fuzzer.cc", 2690 "json/correctness_fuzzer.cc",
2693 ] 2691 ]
2694 deps = [ 2692 deps = [
2695 ":base", 2693 ":base",
2696 ] 2694 ]
2697 } 2695 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698