Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2799083002: Revert of [build] Temporarily switch off goma on gyp bot (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
tandrii(chromium)
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Temporarily switch off goma on gyp bot (patchset #1 id:1 of https://codereview.chromium.org/2802793002/ ) Reason for revert: A different sysroot config fix was required here. Original issue's description: > [build] Temporarily switch off goma on gyp bot > > BUG=chromium:708482 > NOTRY=true > TBR=tandrii@chromium.org > > Review-Url: https://codereview.chromium.org/2802793002 > Cr-Commit-Position: refs/heads/master@{#44418} > Committed: https://chromium.googlesource.com/v8/v8/+/6cf74cb61b0f0e50a42b9fbe2b3d1f3c3dcfc14e TBR=tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:708482 Review-Url: https://codereview.chromium.org/2799083002 Cr-Commit-Position: refs/heads/master@{#44420} Committed: https://chromium.googlesource.com/v8/v8/+/2ac17e34cd9847bac75fdd03a8d65cb4e8b7e213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M infra/mb/mb_config.pyl View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [build] Temporarily switch off goma on gyp bot
3 years, 8 months ago (2017-04-05 20:25:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799083002/1
3 years, 8 months ago (2017-04-05 20:25:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/2ac17e34cd9847bac75fdd03a8d65cb4e8b7e213
3 years, 8 months ago (2017-04-05 20:25:22 UTC) #6
tandrii(chromium)
3 years, 8 months ago (2017-04-05 20:43:45 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698