Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2802793002: [build] Temporarily switch off goma on gyp bot (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
tandrii(chromium)
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Temporarily switch off goma on gyp bot BUG=chromium:708482 NOTRY=true TBR=tandrii@chromium.org Review-Url: https://codereview.chromium.org/2802793002 Cr-Commit-Position: refs/heads/master@{#44418} Committed: https://chromium.googlesource.com/v8/v8/+/6cf74cb61b0f0e50a42b9fbe2b3d1f3c3dcfc14e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M infra/mb/mb_config.pyl View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
TBR - not sure if it really switches off goma, but it's a try. Might ...
3 years, 8 months ago (2017-04-05 18:48:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802793002/1
3 years, 8 months ago (2017-04-05 18:48:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/6cf74cb61b0f0e50a42b9fbe2b3d1f3c3dcfc14e
3 years, 8 months ago (2017-04-05 18:50:16 UTC) #6
tandrii(chromium)
lgtm
3 years, 8 months ago (2017-04-05 19:48:51 UTC) #7
Michael Achenbach
On 2017/04/05 19:48:51, tandrii(chromium) wrote: > lgtm It did switch off goma... but it didn't ...
3 years, 8 months ago (2017-04-05 19:50:00 UTC) #8
Michael Achenbach
3 years, 8 months ago (2017-04-05 20:25:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2799083002/ by machenbach@chromium.org.

The reason for reverting is: A different sysroot config fix was required here..

Powered by Google App Engine
This is Rietveld 408576698