[Sensors] Stop exposing sensor state

[Sensors] Stop exposing sensor state

In the updated specification [1] sensor states are internal slots, the 'state' attribute is moved to the 'boolean activated' attribute.
This CL updates the Sensor implementation and layout tests accordingly.

[1] https://w3c.github.io/sensors/

BUG=606766
Review-Url: https://codereview.chromium.org/2798913002
Cr-Commit-Position: refs/heads/master@{#462434}
Committed: https://chromium.googlesource.com/chromium/src/+/23539089aaee4a68f814b0f42b2ec04885fe69ea

[Mikhail, 2017-04-05 13:45:39]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 13:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2017-04-05 13:46:14]

Description was changed from

==========
[Sensors] Stop exposing sensor state

In the updated specification [1] sensor states are internal slots, the 'state'
attribute is moved to the 'boolean activated' attribute.
This CL updates the Sensor implementation and layout tests accordingly.

[1] https://w3c.github.io/sensors/

BUG=606766
==========

to

==========
[Sensors] Stop exposing sensor state

In the updated specification [1] sensor states are internal slots, the 'state'
attribute is moved to the 'boolean activated' attribute.
This CL updates the Sensor implementation and layout tests accordingly.

[1] https://w3c.github.io/sensors/

BUG=606766
==========

[Mikhail, 2017-04-05 13:46:14]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, haraken@chromium.org, reillyg@chromium.org

[Mikhail, 2017-04-05 13:46:43]

PTAL

[haraken, 2017-04-05 14:07:54]

LGTM

[commit-bot: I haz the power, 2017-04-05 15:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:50:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Reilly Grant (use Gerrit), 2017-04-05 17:21:18]

lgtm with nits

https://codereview.chromium.org/2798913002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/Sensor.idl (right):

https://codereview.chromium.org/2798913002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Sensor.idl:6: //
https://w3c.github.io/sensors/#sensor0
This link should be updated to:

https://w3c.github.io/sensors/#the-sensor-interface

https://codereview.chromium.org/2798913002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Sensor.idl:8: enum SensorState {
SensorState is no longer defined in the specification. Sensor defines its own
enum which we use internally so this definition can be removed.

[shalamov, 2017-04-06 08:36:09]

lgtm

[Mikhail, 2017-04-06 09:39:58]

Thanks for your comments!

https://codereview.chromium.org/2798913002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/Sensor.idl (right):

https://codereview.chromium.org/2798913002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Sensor.idl:6: //
https://w3c.github.io/sensors/#sensor0
On 2017/04/05 17:21:18, Reilly Grant wrote:
> This link should be updated to:
> 
> https://w3c.github.io/sensors/#the-sensor-interface

Done.

https://codereview.chromium.org/2798913002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Sensor.idl:8: enum SensorState {
On 2017/04/05 17:21:18, Reilly Grant wrote:
> SensorState is no longer defined in the specification. Sensor defines its own
> enum which we use internally so this definition can be removed.

Done.

[Mikhail, 2017-04-06 09:40:17]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2017-04-06 09:40:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, reillyg@chromium.org, alexander.shalamov@intel.com
Link to the patchset: https://codereview.chromium.org/2798913002/#ps20001
(title: "Comments from Reilly")

[commit-bot: I haz the power, 2017-04-06 09:40:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 12:03:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491471617209620,
"parent_rev": "d3c31efdb084f2d6111cf5de1b91e2d485f883d3", "commit_rev":
"23539089aaee4a68f814b0f42b2ec04885fe69ea"}

[commit-bot: I haz the power, 2017-04-06 12:04:06]

Description was changed from

==========
[Sensors] Stop exposing sensor state

In the updated specification [1] sensor states are internal slots, the 'state'
attribute is moved to the 'boolean activated' attribute.
This CL updates the Sensor implementation and layout tests accordingly.

[1] https://w3c.github.io/sensors/

BUG=606766
==========

to

==========
[Sensors] Stop exposing sensor state

In the updated specification [1] sensor states are internal slots, the 'state'
attribute is moved to the 'boolean activated' attribute.
This CL updates the Sensor implementation and layout tests accordingly.

[1] https://w3c.github.io/sensors/

BUG=606766

Review-Url: https://codereview.chromium.org/2798913002
Cr-Commit-Position: refs/heads/master@{#462434}
Committed:
https://chromium.googlesource.com/chromium/src/+/23539089aaee4a68f814b0f42b2e...
==========

[commit-bot: I haz the power, 2017-04-06 12:04:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23539089aaee4a68f814b0f42b2e...