Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js

Issue 2798913002: [Sensors] Stop exposing sensor state (Closed)
Patch Set: Comments from Reilly Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
diff --git a/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js b/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
index 7d3c97e46cd7e60e4251b3b8b544df0de2780c12..0a9949d26e1f72f5fcb9de4d1215d88e5b728ace 100644
--- a/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
+++ b/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
@@ -34,7 +34,6 @@ function sensor_mocks(mojo) {
class MockSensor {
constructor(sensorRequest, handle, offset, size, reportingMode) {
this.client_ = null;
- this.expects_modified_reading_ = false;
this.start_should_fail_ = false;
this.reporting_mode_ = reportingMode;
this.sensor_reading_timer_id_ = null;
@@ -129,7 +128,6 @@ function sensor_mocks(mojo) {
reset() {
this.stopReading();
- this.expects_modified_reading_ = false;
this.reading_updates_count_ = 0;
this.start_should_fail_ = false;
this.update_reading_function_ = null;
@@ -162,12 +160,6 @@ function sensor_mocks(mojo) {
this.start_should_fail_ = should_fail;
}
- // Sets flags that asks for a modified reading values at each iteration
- // to initiate 'onchange' event broadcasting.
- setExpectsModifiedReading(expects_modified_reading) {
- this.expects_modified_reading_ = expects_modified_reading;
- }
-
// Returns resolved promise if suspend() was called, rejected otherwise.
suspendCalled() {
return new Promise((resolve, reject) => {
@@ -204,9 +196,7 @@ function sensor_mocks(mojo) {
let timeout = (1 / max_frequency_used) * 1000;
this.sensor_reading_timer_id_ = window.setInterval(() => {
if (this.update_reading_function_) {
- this.update_reading_function_(this.buffer_,
- this.expects_modified_reading_,
- this.reading_updates_count_);
+ this.update_reading_function_(this.buffer_);
this.reading_updates_count_++;
}
if (this.reporting_mode_ === sensor.ReportingMode.ON_CHANGE) {

Powered by Google App Engine
This is Rietveld 408576698