[ozone,views-mus] Build CursorDataFactoryOzone.

[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and
parses it into a ui::CursorData, which is exposes through
PlatformCursor. The views layer has access to PlatformCursor and can
transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037
Review-Url: https://codereview.chromium.org/2798883003
Cr-Commit-Position: refs/heads/master@{#465325}
Committed: https://chromium.googlesource.com/chromium/src/+/d05afac1ecd0d9808289a7151dcb68ae18940852

[Elliot Glaysher, 2017-04-05 21:53:05]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:53:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 22:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:07:06]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-04-05 22:10:36]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 22:11:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 22:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:20:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Elliot Glaysher, 2017-04-05 22:34:09]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 22:34:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-04-05 23:02:43]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:03:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:40:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:40:21]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-06 18:22:09]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 19:31:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:31:56]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-13 19:19:07]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 19:19:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 19:36:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-04-13 19:56:13]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 19:56:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:15:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-04-13 20:16:19]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:16:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-04-13 21:44:19]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 21:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-04-13 21:58:03]

Description was changed from

==========
[ozone] Add an OzonePlatformMus.

Add an ozone platform for when we're running inside a mus client process. This
is mostly the same as the headless version, except that we use a
CursorFactoryOzone which deals in ui::CursorData objects.

BUG=705037
==========

to

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and parses it
into a ui::CursorData, which is exposes through PlatformCursor. The views layer
has access to PlatformCursor and can transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037
==========

[Elliot Glaysher, 2017-04-13 21:58:12]

Description was changed from

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and parses it
into a ui::CursorData, which is exposes through PlatformCursor. The views layer
has access to PlatformCursor and can transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037
==========

to

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and
parses it into a ui::CursorData, which is exposes through
PlatformCursor. The views layer has access to PlatformCursor and can
transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037
==========

[commit-bot: I haz the power, 2017-04-13 22:51:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 22:51:21]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-13 22:58:16]

erg@chromium.org changed reviewers:
+ jam@chromium.org, sadrul@chromium.org

[Elliot Glaysher, 2017-04-13 22:58:17]

this patch continues to thread CursorData from the renderer through the mus
using browser process to mus. it doesn't yet transmit the data from mus-chrome
to mus; that's the next patch.

sadrul: ui

jam: exo and content

[jam, 2017-04-13 23:12:57]

On 2017/04/13 22:58:17, Elliot Glaysher wrote:
> this patch continues to thread CursorData from the renderer through the mus
> using browser process to mus. it doesn't yet transmit the data from mus-chrome
> to mus; that's the next patch.
> 
> sadrul: ui
> 
> jam: exo and content

rs lgtm

[sadrul, 2017-04-18 17:04:59]

lgtm

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
File ui/base/cursor/ozone/cursor_data_factory_ozone.cc (right):

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:20:
ozone->AssertIsACusrorDataOzone();
Should the magic cookie/assertions be behind DCHECK_IS_ON()?

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:66: return
ToPlatformCursor(cursor);
So this is essentially: make_scoped_refptr....release(), which is somewhat
unfortunate. I wish the cursor data types were better defined.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:97:
scoped_refptr<CursorDataOzone> cursor = scoped_refptr<CursorDataOzone>(
make_scoped_refptr?

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:99: default_cursors_[type] =
cursor;
std::move(cursor)

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
File ui/base/cursor/ozone/cursor_data_factory_ozone.h (right):

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.h:30: CursorDataOzone(const
ui::CursorData& data);
explicit

[Elliot Glaysher, 2017-04-18 17:58:48]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 17:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:16:54]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-18 19:17:30]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2017-04-18 19:17:31]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2798883003/#ps200001
(title: "sadrul comments")

[commit-bot: I haz the power, 2017-04-18 19:18:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:23:27]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1492543050918240,
"parent_rev": "1ac5a973f47b2052df313bab17da120fae22190e", "commit_rev":
"d05afac1ecd0d9808289a7151dcb68ae18940852"}

[commit-bot: I haz the power, 2017-04-18 19:24:14]

Description was changed from

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and
parses it into a ui::CursorData, which is exposes through
PlatformCursor. The views layer has access to PlatformCursor and can
transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037
==========

to

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and
parses it into a ui::CursorData, which is exposes through
PlatformCursor. The views layer has access to PlatformCursor and can
transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037

Review-Url: https://codereview.chromium.org/2798883003
Cr-Commit-Position: refs/heads/master@{#465325}
Committed:
https://chromium.googlesource.com/chromium/src/+/d05afac1ecd0d9808289a7151dcb...
==========

[commit-bot: I haz the power, 2017-04-18 19:24:16]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/d05afac1ecd0d9808289a7151dcb...

[sadrul, 2017-04-18 20:10:37]

Oh btw: update the CL title please? (because everytime I see OzonePlatformMus, I
go 'oh no why')

[Elliot Glaysher, 2017-04-18 20:11:15]

Description was changed from

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and
parses it into a ui::CursorData, which is exposes through
PlatformCursor. The views layer has access to PlatformCursor and can
transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037

Review-Url: https://codereview.chromium.org/2798883003
Cr-Commit-Position: refs/heads/master@{#465325}
Committed:
https://chromium.googlesource.com/chromium/src/+/d05afac1ecd0d9808289a7151dcb...
==========

to

==========
[ozone,views-mus] Build CursorDataFactoryOzone.

This class is-a CursorFactoryOzone. It takes data from WebCursor and
parses it into a ui::CursorData, which is exposes through
PlatformCursor. The views layer has access to PlatformCursor and can
transmit this data to a remote process.

[Next patch: modify the mus bindings to take CursorData instead of a
CursorType.]

BUG=705037

Review-Url: https://codereview.chromium.org/2798883003
Cr-Commit-Position: refs/heads/master@{#465325}
Committed:
https://chromium.googlesource.com/chromium/src/+/d05afac1ecd0d9808289a7151dcb...
==========

[Elliot Glaysher, 2017-04-18 20:11:58]

done, but that probably doesn't matter since it was committed.

(Why do we even have subjects anyway? They go stale in most patches that I do.)

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
File ui/base/cursor/ozone/cursor_data_factory_ozone.cc (right):

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:20:
ozone->AssertIsACusrorDataOzone();
On 2017/04/18 17:04:59, sadrul wrote:
> Should the magic cookie/assertions be behind DCHECK_IS_ON()?

Done.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:66: return
ToPlatformCursor(cursor);
On 2017/04/18 17:04:59, sadrul wrote:
> So this is essentially: make_scoped_refptr....release(), which is somewhat
> unfortunate. I wish the cursor data types were better defined.

Acknowledged.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:97:
scoped_refptr<CursorDataOzone> cursor = scoped_refptr<CursorDataOzone>(
On 2017/04/18 17:04:59, sadrul wrote:
> make_scoped_refptr?

Done.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:99: default_cursors_[type] =
cursor;
On 2017/04/18 17:04:59, sadrul wrote:
> std::move(cursor)

Done.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
File ui/base/cursor/ozone/cursor_data_factory_ozone.h (right):

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.h:30: CursorDataOzone(const
ui::CursorData& data);
On 2017/04/18 17:04:59, sadrul wrote:
> explicit

Done.

[Elliot Glaysher, 2017-04-18 20:11:59]

done, but that probably doesn't matter since it was committed.

(Why do we even have subjects anyway? They go stale in most patches that I do.)

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
File ui/base/cursor/ozone/cursor_data_factory_ozone.cc (right):

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:20:
ozone->AssertIsACusrorDataOzone();
On 2017/04/18 17:04:59, sadrul wrote:
> Should the magic cookie/assertions be behind DCHECK_IS_ON()?

Done.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:66: return
ToPlatformCursor(cursor);
On 2017/04/18 17:04:59, sadrul wrote:
> So this is essentially: make_scoped_refptr....release(), which is somewhat
> unfortunate. I wish the cursor data types were better defined.

Acknowledged.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.cc:97:
scoped_refptr<CursorDataOzone> cursor = scoped_refptr<CursorDataOzone>(
On 2017/04/18 17:04:59, sadrul wrote:
> make_scoped_refptr?

Done.

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
File ui/base/cursor/ozone/cursor_data_factory_ozone.h (right):

https://codereview.chromium.org/2798883003/diff/180001/ui/base/cursor/ozone/c...
ui/base/cursor/ozone/cursor_data_factory_ozone.h:30: CursorDataOzone(const
ui::CursorData& data);
On 2017/04/18 17:04:59, sadrul wrote:
> explicit

Done.