[ios clean] Updates all BrowserCoordinator to the new rule

[ios clean] Updates all BrowserCoordinator to the new rule

The new rule is that coordinators don't decide how they are presented
(presentation, containment, etc.). The parent can decide in
-childCoordinatorDidStart|WillStop.
That also means that the CoordinationContext is unnecessary.

BUG=none
R=marq@chromium.org,rohitrao@chromium.org,edchin@chromium.org,sczs@chromium.org

Review-Url: https://codereview.chromium.org/2798833003
Cr-Commit-Position: refs/heads/master@{#462679}
Committed: https://chromium.googlesource.com/chromium/src/+/7d3049a95961ec0b6601a15a0b0335e11acc01c8

[lpromero, 2017-04-05 18:19:35]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:20:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-05 18:21:04]

Rohit, did you rely on the coordinator context in wasAddedToParentCoordinator in
one of your CL?

Also, I need to think about how the new pattern deals with overlays, now that we
rely on knowing the presenter controller.

[lpromero, 2017-04-05 18:21:21]

Description was changed from

==========
[ios clean] Updates all BrowserCoordinator to the new rule

The new rule is that coordinators don't decide how they are presented
(presentation, containment, etc.). The parent can decide in
-childCoordinatorDidStart|WillStop.
That also means that the CoordinationContext is unnecessary.

BUG=none
R=marq@chromium.org,rohitrao@chromium.org,edchin@chromium.org,edchin@chromium...
==========

to

==========
[ios clean] Updates all BrowserCoordinator to the new rule

The new rule is that coordinators don't decide how they are presented
(presentation, containment, etc.). The parent can decide in
-childCoordinatorDidStart|WillStop.
That also means that the CoordinationContext is unnecessary.

BUG=none
R=marq@chromium.org,rohitrao@chromium.org,edchin@chromium.org,sczs@chromium.org
==========

[lpromero, 2017-04-05 18:21:21]

lpromero@chromium.org changed reviewers:
+ sczs@chromium.org

[rohitrao (ping after 24h), 2017-04-05 18:23:57]

My code uses self.browser, but I don't need the context for anything.

[commit-bot: I haz the power, 2017-04-05 18:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:24:44]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2017-04-06 13:50:47]

lgtm

[lpromero, 2017-04-06 17:01:22]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:02:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 17:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 17:12:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lpromero, 2017-04-06 17:22:49]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:23:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:42:25]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-04-06 23:14:59]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-04-06 23:14:59]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2798833003/#ps40001
(title: "Fix unittests")

[commit-bot: I haz the power, 2017-04-06 23:15:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:29:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491520499003110,
"parent_rev": "09b06cad7bc4b38fa64142b16a0c6adcbcc875b4", "commit_rev":
"7d3049a95961ec0b6601a15a0b0335e11acc01c8"}

[commit-bot: I haz the power, 2017-04-06 23:30:11]

Description was changed from

==========
[ios clean] Updates all BrowserCoordinator to the new rule

The new rule is that coordinators don't decide how they are presented
(presentation, containment, etc.). The parent can decide in
-childCoordinatorDidStart|WillStop.
That also means that the CoordinationContext is unnecessary.

BUG=none
R=marq@chromium.org,rohitrao@chromium.org,edchin@chromium.org,sczs@chromium.org
==========

to

==========
[ios clean] Updates all BrowserCoordinator to the new rule

The new rule is that coordinators don't decide how they are presented
(presentation, containment, etc.). The parent can decide in
-childCoordinatorDidStart|WillStop.
That also means that the CoordinationContext is unnecessary.

BUG=none
R=marq@chromium.org,rohitrao@chromium.org,edchin@chromium.org,sczs@chromium.org

Review-Url: https://codereview.chromium.org/2798833003
Cr-Commit-Position: refs/heads/master@{#462679}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d3049a95961ec0b6601a15a0b03...
==========

[commit-bot: I haz the power, 2017-04-06 23:30:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7d3049a95961ec0b6601a15a0b03...