Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2798733002: Block onScroll if input MotionEvents are null (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by mdjones
Modified:
4 months, 1 week ago
Reviewers:
Khushal
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Block onScroll if input MotionEvents are null This change is to fix a long-standing crash where the inputs provided to the GestureEventFilter are null. If either of the two events are null, an early return is triggered. BUG=656603 Review-Url: https://codereview.chromium.org/2798733002 Cr-Commit-Position: refs/heads/master@{#462084} Committed: https://chromium.googlesource.com/chromium/src/+/7c32fc6bf0cb418e50e7f3590537e841477cad9e

Patch Set 1 #

Total comments: 2

Patch Set 2 : doc #

Messages

Total messages: 14 (7 generated)
mdjones
Welp, here it is.
4 months, 1 week ago (2017-04-04 22:03:23 UTC) #2
Khushal
lgtm https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java (right): https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java#newcode101 chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java:101: if (e1 == null || e2 == null) ...
4 months, 1 week ago (2017-04-04 22:10:10 UTC) #3
mdjones
https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java (right): https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java#newcode101 chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java:101: if (e1 == null || e2 == null) return ...
4 months, 1 week ago (2017-04-04 22:16:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798733002/20001
4 months, 1 week ago (2017-04-04 22:17:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/264572)
4 months, 1 week ago (2017-04-05 01:34:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798733002/20001
4 months, 1 week ago (2017-04-05 15:02:25 UTC) #11
commit-bot: I haz the power
4 months, 1 week ago (2017-04-05 15:47:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c32fc6bf0cb418e50e7f3590537...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b