Block onScroll if input MotionEvents are null

Block onScroll if input MotionEvents are null

This change is to fix a long-standing crash where the inputs provided
to the GestureEventFilter are null. If either of the two events are
null, an early return is triggered.

BUG=656603
Review-Url: https://codereview.chromium.org/2798733002
Cr-Commit-Position: refs/heads/master@{#462084}
Committed: https://chromium.googlesource.com/chromium/src/+/7c32fc6bf0cb418e50e7f3590537e841477cad9e

[mdjones, 2017-04-04 22:03:23]

mdjones@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[mdjones, 2017-04-04 22:03:23]

Welp, here it is.

[Khushal, 2017-04-04 22:10:10]

lgtm

https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java
(right):

https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java:101:
if (e1 == null || e2 == null) return false;
Could we add a comment here that says this should ideally never happen but is a
workaround, with the bug mentioned?

[mdjones, 2017-04-04 22:16:24]

https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java
(right):

https://codereview.chromium.org/2798733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java:101:
if (e1 == null || e2 == null) return false;
On 2017/04/04 22:10:10, Khushal wrote:
> Could we add a comment here that says this should ideally never happen but is
a
> workaround, with the bug mentioned?

Done.

[mdjones, 2017-04-04 22:16:55]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-04-04 22:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2798733002/#ps20001
(title: "doc")

[commit-bot: I haz the power, 2017-04-04 22:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 01:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:34:08]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mdjones, 2017-04-05 15:01:38]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:02:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:46:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491404498163360,
"parent_rev": "cfaf497e50484a20c662f4bb57e3ce2c67463ed2", "commit_rev":
"7c32fc6bf0cb418e50e7f3590537e841477cad9e"}

[commit-bot: I haz the power, 2017-04-05 15:47:07]

Description was changed from

==========
Block onScroll if input MotionEvents are null

This change is to fix a long-standing crash where the inputs provided
to the GestureEventFilter are null. If either of the two events are
null, an early return is triggered.

BUG=656603
==========

to

==========
Block onScroll if input MotionEvents are null

This change is to fix a long-standing crash where the inputs provided
to the GestureEventFilter are null. If either of the two events are
null, an early return is triggered.

BUG=656603

Review-Url: https://codereview.chromium.org/2798733002
Cr-Commit-Position: refs/heads/master@{#462084}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c32fc6bf0cb418e50e7f3590537...
==========

[commit-bot: I haz the power, 2017-04-05 15:47:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c32fc6bf0cb418e50e7f3590537...