Chromium Code Reviews
DescriptionRevert "Destroy the old RenderWidgetHostView when swapping out a main frame."
It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making further
changes to the code intractable.
Note: this is a manual revert because of conflicts
Original description:
> Destroy the old RenderWidgetHostView when swapping out a main frame.
>
> This fixes an issue where the old RenderView is reused by a new remote
> subframe. We shouldn't be leaking resources, because now we are already
> hiding the unused RenderView in the renderer, when the local main frame
> gets detached and the WebViewFrameWidget is closed.
>
> BUG=638375
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2496233003
> Cr-Commit-Position: refs/heads/master@{#438516}
BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2786443003
Cr-Commit-Position: refs/heads/master@{#461459}
(cherry picked from commit 00cf9403c34aea924ffecd736f93e06421e10e15)
Review-Url: https://codereview.chromium.org/2798673002 .
Cr-Commit-Position: refs/branch-heads/3029@{#575}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/204f85e5d72d7da5c76d6a38045304c4fb594fd0
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||