Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making further
changes to the code intractable.
Note: this is a manual revert because of conflicts

Original description:
>    Destroy the old RenderWidgetHostView when swapping out a main frame.
>    
>    This fixes an issue where the old RenderView is reused by a new remote
>    subframe. We shouldn't be leaking resources, because now we are already
>    hiding the unused RenderView in the renderer, when the local main frame
>    gets detached and the WebViewFrameWidget is closed.
>    
>    BUG=638375
>    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>    
>    Review-Url: https://codereview.chromium.org/2496233003
>    Cr-Commit-Position: refs/heads/master@{#438516}

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2786443003
Cr-Commit-Position: refs/heads/master@{#461459}
Committed: https://chromium.googlesource.com/chromium/src/+/00cf9403c34aea924ffecd736f93e06421e10e15

[piman, 2017-03-29 00:43:12]

Description was changed from

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

This reverts commit 9431efdc7b0146ef74f75ce160f2ba343ca2d550.

BUG=701988
==========

to

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

This reverts commit 9431efdc7b0146ef74f75ce160f2ba343ca2d550.

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[piman, 2017-03-29 00:43:14]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 00:43:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 02:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 02:17:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Saman Sami, 2017-03-29 03:50:16]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 03:50:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 05:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 05:15:58]

Dry run: This issue passed the CQ dry run.

[Saman Sami, 2017-03-29 14:17:45]

Description was changed from

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

This reverts commit 9431efdc7b0146ef74f75ce160f2ba343ca2d550.

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

This reverts commit 9431efdc7b0146ef74f75ce160f2ba343ca2d550.

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-29 14:17:45]

samans@chromium.org changed reviewers:
- samans@chromium.org

[piman, 2017-03-30 23:11:40]

Description was changed from

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

This reverts commit 9431efdc7b0146ef74f75ce160f2ba343ca2d550.

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making
further
changes to the code intractable.
Note: this is a manual revert because of conflicts

>    Destroy the old RenderWidgetHostView when swapping out a main frame.
>    
>    This fixes an issue where the old RenderView is reused by a new remote
>    subframe. We shouldn't be leaking resources, because now we are already
>    hiding the unused RenderView in the renderer, when the local main frame
>    gets detached and the WebViewFrameWidget is closed.
>    
>    BUG=638375
>    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>    
>    Review-Url: https://codereview.chromium.org/2496233003
>    Cr-Commit-Position: refs/heads/master@{#438516}

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[piman, 2017-03-30 23:12:08]

Description was changed from

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making
further
changes to the code intractable.
Note: this is a manual revert because of conflicts

>    Destroy the old RenderWidgetHostView when swapping out a main frame.
>    
>    This fixes an issue where the old RenderView is reused by a new remote
>    subframe. We shouldn't be leaking resources, because now we are already
>    hiding the unused RenderView in the renderer, when the local main frame
>    gets detached and the WebViewFrameWidget is closed.
>    
>    BUG=638375
>    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>    
>    Review-Url: https://codereview.chromium.org/2496233003
>    Cr-Commit-Position: refs/heads/master@{#438516}

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making
further
changes to the code intractable.
Note: this is a manual revert because of conflicts

Original description:
>    Destroy the old RenderWidgetHostView when swapping out a main frame.
>    
>    This fixes an issue where the old RenderView is reused by a new remote
>    subframe. We shouldn't be leaking resources, because now we are already
>    hiding the unused RenderView in the renderer, when the local main frame
>    gets detached and the WebViewFrameWidget is closed.
>    
>    BUG=638375
>    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>    
>    Review-Url: https://codereview.chromium.org/2496233003
>    Cr-Commit-Position: refs/heads/master@{#438516}

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[piman, 2017-03-30 23:12:19]

piman@chromium.org changed reviewers:
+ lfg@chromium.org

[lfg, 2017-03-31 14:28:43]

lgtm

[piman, 2017-04-03 16:04:43]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2017-04-03 16:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:09:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491235483405440, "parent_rev":
"910b408e9d1ba5c36b5663a682b70cfc43e58a53", "commit_rev":
"00cf9403c34aea924ffecd736f93e06421e10e15"}

[commit-bot: I haz the power, 2017-04-03 17:10:17]

Description was changed from

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making
further
changes to the code intractable.
Note: this is a manual revert because of conflicts

Original description:
>    Destroy the old RenderWidgetHostView when swapping out a main frame.
>    
>    This fixes an issue where the old RenderView is reused by a new remote
>    subframe. We shouldn't be leaking resources, because now we are already
>    hiding the unused RenderView in the renderer, when the local main frame
>    gets detached and the WebViewFrameWidget is closed.
>    
>    BUG=638375
>    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>    
>    Review-Url: https://codereview.chromium.org/2496233003
>    Cr-Commit-Position: refs/heads/master@{#438516}

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Destroy the old RenderWidgetHostView when swapping out a main frame."

It makes the assumption that a RenderWidget can talk to different
RenderWidgetHostView over its lifetime, but this assumption cannot be satisfied
by the code, and so this causes immediate problems (renderer hangs, tests
failures and flakiness) as well as fundamental consistency problems making
further
changes to the code intractable.
Note: this is a manual revert because of conflicts

Original description:
>    Destroy the old RenderWidgetHostView when swapping out a main frame.
>    
>    This fixes an issue where the old RenderView is reused by a new remote
>    subframe. We shouldn't be leaking resources, because now we are already
>    hiding the unused RenderView in the renderer, when the local main frame
>    gets detached and the WebViewFrameWidget is closed.
>    
>    BUG=638375
>    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>    
>    Review-Url: https://codereview.chromium.org/2496233003
>    Cr-Commit-Position: refs/heads/master@{#438516}

BUG=701988
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2786443003
Cr-Commit-Position: refs/heads/master@{#461459}
Committed:
https://chromium.googlesource.com/chromium/src/+/00cf9403c34aea924ffecd736f93...
==========

[commit-bot: I haz the power, 2017-04-03 17:10:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00cf9403c34aea924ffecd736f93...