Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2798593002: Count how often we'd throw for invalid URLs in window.open (Closed)

Created:
3 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Count how often we'd throw for invalid URLs in window.open BUG=708135 R=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2798593002 Cr-Commit-Position: refs/heads/master@{#461700} Committed: https://chromium.googlesource.com/chromium/src/+/66cca6c78f63989a3834b992245d1764fb85c6e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-04-04 11:38:46 UTC) #1
Mike West
LGTM. But please land it after you LGTM the patch I just sent you that ...
3 years, 8 months ago (2017-04-04 11:59:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798593002/1
3 years, 8 months ago (2017-04-04 11:59:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798593002/1
3 years, 8 months ago (2017-04-04 12:29:48 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 13:51:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66cca6c78f63989a3834b992245d...

Powered by Google App Engine
This is Rietveld 408576698